Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevents Perl warning WS2000 #1083

Merged
merged 2 commits into from
Mar 7, 2022
Merged

Conversation

elektron-bbs
Copy link
Contributor

  • Please check if the PR fulfills these requirements
  • Tests for the changes have been added / modified (needed for for bug fixes / features)
  • commandref has been added / updated (needed for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
  • Bugfix (please link issue)
  • Feature enhancement
  • Documentation update
  • Unittest enhancement
  • other
  • What is the current behavior?
    (You can also link to an open issue here, if this describes the current behavior)
    PERL WARNING: Use of uninitialized value in join or string at FHEM/lib/SD_Protocols.pm line 1436.

  • What is the new behavior (if this is a feature change)?
    no PERL WARNING

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    no

  • Other information:

@codecov
Copy link

codecov bot commented Mar 7, 2022

Codecov Report

Merging #1083 (c65c746) into master (2d2517a) will increase coverage by 0.13%.
The diff coverage is 25.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1083      +/-   ##
==========================================
+ Coverage   63.50%   63.63%   +0.13%     
==========================================
  Files         128      130       +2     
  Lines        9475     9529      +54     
  Branches     1503     1510       +7     
==========================================
+ Hits         6017     6064      +47     
  Misses       2300     2300              
- Partials     1158     1165       +7     
Flag Coverage Δ
fhem 55.39% <25.00%> (+0.14%) ⬆️
modules 63.63% <25.00%> (+0.13%) ⬆️
perl 90.59% <25.00%> (+0.10%) ⬆️
unittests 63.63% <25.00%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
FHEM/lib/SD_ProtocolData.pm 100.00% <ø> (ø)
FHEM/lib/SD_Protocols.pm 79.45% <25.00%> (+0.31%) ⬆️
t/FHEM/14_BresserTemeo/09_parseDatat.t 80.00% <0.00%> (ø)
t/FHEM/14_SD_WS07/09_parseDatat.t 80.00% <0.00%> (ø)
FHEM/10_SD_Rojaflex.pm 71.54% <0.00%> (+0.40%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d2517a...c65c746. Read the comment docs.

@elektron-bbs elektron-bbs merged commit daa44d1 into master Mar 7, 2022
@elektron-bbs elektron-bbs deleted the master_WS2000-PERL-WARNING branch April 11, 2022 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants