Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clone Protocol Object for every definition #1084

Merged
merged 9 commits into from
Mar 16, 2022
Merged

Conversation

sidey79
Copy link
Contributor

@sidey79 sidey79 commented Mar 12, 2022

  • Please check if the PR fulfills these requirements
  • Tests for the changes have been added / modified (needed for for bug fixes / features)
  • commandref has been added / updated (needed for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
  • Bugfix (please link issue)
  • Feature enhancement
  • Documentation update
  • Unittest enhancement
  • other
  • What is the current behavior?
    (You can also link to an open issue here, if this describes the current behavior)

#1076

  • What is the new behavior (if this is a feature change)?

Every definition of SIGNALduino gets it's own protocol object

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

  • Other information:

sidey79 and others added 2 commits March 12, 2022 12:32
clone Protocol Object for every definition
@sidey79 sidey79 added the bug label Mar 12, 2022
@sidey79 sidey79 changed the title clone Protocol Object for every definition WIP: clone Protocol Object for every definition Mar 12, 2022
@codecov
Copy link

codecov bot commented Mar 12, 2022

Codecov Report

Merging #1084 (f8a2d6b) into master (8edcf22) will increase coverage by 0.06%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1084      +/-   ##
==========================================
+ Coverage   63.60%   63.66%   +0.06%     
==========================================
  Files         131      132       +1     
  Lines        9500     9524      +24     
  Branches     1505     1508       +3     
==========================================
+ Hits         6042     6063      +21     
  Misses       2296     2296              
- Partials     1162     1165       +3     
Flag Coverage Δ
fhem 55.51% <100.00%> (+0.19%) ⬆️
modules 63.66% <100.00%> (+0.06%) ⬆️
perl 90.59% <ø> (ø)
unittests 63.66% <100.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
FHEM/00_SIGNALduino.pm 63.74% <100.00%> (+0.04%) ⬆️
t/FHEM/00_SIGNALduino/01_SIGNALduino_Define.t 100.00% <100.00%> (ø)
t/FHEM/14_FLAMINGO/09_parseDatat.t 80.00% <0.00%> (ø)
FHEM/lib/SD_Protocols.pm 79.56% <0.00%> (+0.10%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@sidey79 sidey79 linked an issue Mar 12, 2022 that may be closed by this pull request
@sidey79
Copy link
Contributor Author

sidey79 commented Mar 12, 2022

@elektron-bbs

Ich habe es noch nicht getestet und noch keinen Test erstellt, welcher den Fehler provoziert, aber das wäre meine Idee.

@elektron-bbs
Copy link
Contributor

Ich glaube, das passt so. Bei meinen Versuchen hatte ich jetzt die richtigen SIGNALduinos in den Logs.

sidey79 and others added 6 commits March 12, 2022 18:24
test extended to verify correct logging of protocolObject
extended test to verify correct callback logging
code cleanup
@sidey79
Copy link
Contributor Author

sidey79 commented Mar 12, 2022

@elektron-bbs

Ich habe einen Test ergänzt, der diesen Fehler gefunden hat.
Er wurde dadurch behoben. :)

Ich habe den Code noch etwas aufgeräumt. Nebenwirkungen vermute ich jetzt keine.

@sidey79 sidey79 changed the title WIP: clone Protocol Object for every definition clone Protocol Object for every definition Mar 12, 2022
Copy link
Contributor

@elektron-bbs elektron-bbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sollte passen...

@sidey79 sidey79 merged commit 6a3586b into master Mar 16, 2022
@sidey79 sidey79 deleted the sidey79/issue1076 branch March 16, 2022 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

falscher Name des SIGNALduino in den Logs
3 participants