-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clone Protocol Object for every definition #1084
Conversation
clone Protocol Object for every definition
Codecov Report
@@ Coverage Diff @@
## master #1084 +/- ##
==========================================
+ Coverage 63.60% 63.66% +0.06%
==========================================
Files 131 132 +1
Lines 9500 9524 +24
Branches 1505 1508 +3
==========================================
+ Hits 6042 6063 +21
Misses 2296 2296
- Partials 1162 1165 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Ich habe es noch nicht getestet und noch keinen Test erstellt, welcher den Fehler provoziert, aber das wäre meine Idee. |
Ich glaube, das passt so. Bei meinen Versuchen hatte ich jetzt die richtigen SIGNALduinos in den Logs. |
test extended to verify correct logging of protocolObject
extended test to verify correct callback logging
code cleanup
…into sidey79/issue1076
Ich habe einen Test ergänzt, der diesen Fehler gefunden hat. Ich habe den Code noch etwas aufgeräumt. Nebenwirkungen vermute ich jetzt keine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sollte passen...
(You can also link to an open issue here, if this describes the current behavior)
#1076
Every definition of SIGNALduino gets it's own protocol object
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Other information: