Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SD_GT add attributes repeats and disableSetAllFunction #1146

Merged
merged 4 commits into from
Jan 9, 2023

Conversation

elektron-bbs
Copy link
Contributor

  • Please check if the PR fulfills these requirements
  • Tests for the changes have been added / modified (needed for for bug fixes / features)
  • commandref has been added / updated (needed for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
  • Bugfix (please link issue)
  • Feature enhancement
  • Documentation update
  • Unittest enhancement
  • other
  • What is the current behavior?
    (You can also link to an open issue here, if this describes the current behavior)
    SD_GT feature request #1138

  • What is the new behavior (if this is a feature change)?
    add attributes repeats and disableSetAllFunction
    in commandref, change format "a name="SD_GT"" to "a id="SD_GT""

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    no

  • Other information:

elektron-bbs and others added 4 commits January 5, 2023 20:42
add attributes repeats and disableSetAllFunction
commandref, change format <a name="SD_GT"> to <a id="SD_GT">
Copy link
Contributor

@sidey79 sidey79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generelle Frage:

Die anderen Definition vom gleichen Typ, könnten wir doch effizienter über $modules{SD_GT}{defptr} anstelle %defs suchen oder?

@elektron-bbs elektron-bbs merged commit d0c2ed2 into master Jan 9, 2023
@elektron-bbs
Copy link
Contributor Author

Müsste ich mir mal genauer ansehen. Ich habe auch schon an devspec2array gedacht.
Ich habe es erst mal so übernommen.
Was mir bei diesem Pull Request aufgefallen ist: Es wurden beim Erstellen gar keine Tests durchgeführt. Der letzte Testdurchlauf war wohl gestern beim "Merge branch 'master' into master_SD_GT_feature".

@sidey79
Copy link
Contributor

sidey79 commented Jan 9, 2023

Kann sein, dass das eröffnen einen PRs keine Jobs erzeugt. Ist mir vielleicht noch nie aufgefallen, weil ich noch mal anschließend was gepusht habe. Hmm.

devspec2array durchsucht auch jedes Element in %defs ;) $modules{defptr} müsste ggf. halt beim define explizit mit gesetzt werden. Aktuell wird es glaube ich nur in parse gesetzt.

@elektron-bbs elektron-bbs deleted the master_SD_GT_feature branch February 20, 2023 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants