Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inkbird IBS-P01R Pool Thermometer #1149

Merged
merged 21 commits into from
Jan 14, 2023
Merged

Conversation

elektron-bbs
Copy link
Contributor

  • Please check if the PR fulfills these requirements
  • Tests for the changes have been added / modified (needed for for bug fixes / features)
  • commandref has been added / updated (needed for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
  • Bugfix (please link issue)
  • Feature enhancement
  • Documentation update
  • Unittest enhancement
  • other
  • What is the current behavior?
    (You can also link to an open issue here, if this describes the current behavior)
    No reception of this sensor, see https://forum.fhem.de/index.php/topic,128945.0.html.

  • What is the new behavior (if this is a feature change)?
    Reception and evaluation of the sensor data works.

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    no

  • Other information:

@codecov
Copy link

codecov bot commented Jan 13, 2023

Codecov Report

Merging #1149 (8af7810) into master (a4040b1) will increase coverage by 0.42%.
The diff coverage is 74.28%.

@@            Coverage Diff             @@
##           master    #1149      +/-   ##
==========================================
+ Coverage   66.92%   67.35%   +0.42%     
==========================================
  Files         133      135       +2     
  Lines        9784     9838      +54     
  Branches     1572     1577       +5     
==========================================
+ Hits         6548     6626      +78     
+ Misses       1945     1916      -29     
- Partials     1291     1296       +5     
Flag Coverage Δ
fhem 56.96% <74.28%> (+0.51%) ⬆️
modules 67.35% <74.28%> (+0.42%) ⬆️
perl 90.33% <ø> (+0.24%) ⬆️
unittests 67.35% <74.28%> (+0.42%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
FHEM/lib/SD_ProtocolData.pm 100.00% <ø> (ø)
FHEM/14_SD_WS.pm 68.33% <73.52%> (+0.22%) ⬆️
FHEM/00_SIGNALduino.pm 64.09% <100.00%> (+0.44%) ⬆️
t/FHEM/14_SD_AS/00_load.t
t/FHEM/14_FLAMINGO/09_parseData.t
t/FHEM/14_SD_UT/00_load.t 100.00% <0.00%> (ø)
t/FHEM/10_SD_Rojaflex/09_parseData.t 94.11% <0.00%> (ø)
t/FHEM/14_Hideki/00_load.t 100.00% <0.00%> (ø)
t/FHEM/14_SD_AS/09_parseData.t 94.11% <0.00%> (ø)
FHEM/lib/SD_Protocols.pm 78.48% <0.00%> (+0.41%) ⬆️
... and 2 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@elektron-bbs elektron-bbs merged commit 491b4b3 into master Jan 14, 2023
@HomeAutoUser
Copy link
Contributor

@sidey79 | @elektron-bbs kann es durchaus möglich sein, das hier bei den Tests etwas durch die Lappen ging?

Hier gibt es einen Schlüssel welcher nur test beziffert ist. Überall heißt dieser tests wo auch setreadings definiert wurden.
https://github.com/RFD-FHEM/RFFHEM/blob/master/t/FHEM/14_SD_WS/testData.json#L234:L244

Bitte mal prüfen.

@elektron-bbs
Copy link
Contributor Author

Sieht so aus, ist schon seit Dezember so drin: 0cbecba
Betrifft aber BRESSER 6-in-1.

@sidey79
Copy link
Contributor

sidey79 commented Jan 30, 2023

Ja, da fehlt ein s

HomeAutoUser added a commit that referenced this pull request Jan 30, 2023
14_SD_WS - removal of unnecessary details and fix testdata #1149 (comment)
@HomeAutoUser HomeAutoUser mentioned this pull request Jan 30, 2023
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants