Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support and for FREQEST register value #1168

Merged
merged 18 commits into from
Aug 15, 2023
Merged

Support and for FREQEST register value #1168

merged 18 commits into from
Aug 15, 2023

Conversation

sidey79
Copy link
Contributor

@sidey79 sidey79 commented Apr 16, 2023

  • Added support and logoutput of FREQEST register value
  • Added tests for new optional value
  • Please check if the PR fulfills these requirements
  • Tests for the changes have been added / modified (needed for for bug fixes / features)
  • commandref has been added / updated (needed for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
  • Bugfix (please link issue)
  • Feature enhancement
  • Documentation update
  • Unittest enhancement
  • other
  • What is the current behavior?
    (You can also link to an open issue here, if this describes the current behavior)

Value with A= with Register Value FREQEST causes faulty message error

2023.04.16 19:15:27.242 3: signalESP_2: Parse_MN, faulty msg: MN;D=40013E3C90015CE78F20AA99061D;R=210;A=235;

  • What is the new behavior (if this is a feature change)?

MN Message with an A= Value is optional and accepted

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

no

  • Other information:

RFD-FHEM/SIGNALDuino#275

@codecov
Copy link

codecov bot commented Apr 16, 2023

Codecov Report

Merging #1168 (594414e) into master (2f4ce9e) will increase coverage by 0.06%.
The diff coverage is 71.42%.

@@            Coverage Diff             @@
##           master    #1168      +/-   ##
==========================================
+ Coverage   67.63%   67.70%   +0.06%     
==========================================
  Files         133      136       +3     
  Lines        9841     9877      +36     
  Branches     1576     1579       +3     
==========================================
+ Hits         6656     6687      +31     
- Misses       1884     1887       +3     
- Partials     1301     1303       +2     
Flag Coverage Δ
fhem 57.40% <71.42%> (+0.09%) ⬆️
modules 67.70% <71.42%> (+0.06%) ⬆️
perl 90.46% <ø> (+0.12%) ⬆️
unittests 67.70% <71.42%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
t/FHEM/00_SIGNALduino/01_SIGNALduino_Parse_MN.t 100.00% <ø> (ø)
...FHEM/00_SIGNALduino/02_SIGNALduino_Split_Message.t 100.00% <ø> (ø)
FHEM/00_SIGNALduino.pm 64.31% <71.42%> (+0.40%) ⬆️

... and 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

- Added support and logoutput of FREQEST register value
- Added tests for new optional value
corrected syntax
@HomeAutoUser
Copy link
Contributor

HomeAutoUser commented Apr 17, 2023

2023.04.16 19:15:27.242 3: signalESP_2: Parse_MN, faulty msg: MN;D=40013E3C90015CE78F20AA99061D;R=210;A=235;

Was für ein Wert (A) ist das?
Sind das 235 Hz Abweichung??

@sidey79
Copy link
Contributor Author

sidey79 commented Apr 17, 2023

Das ist der Wert aus dem Register FREQEST.
Wenn ich das halbwegs richtig verstanden habe, kann man den in ein anderes Register schreiben um die Frequenz anzupassen

@elektron-bbs
Copy link
Contributor

elektron-bbs commented Apr 17, 2023

So ist es. Grundlage ist Design Note DN015 - Permanent Frequency Offset Compensation SWRA159A.

@sidey79
Soll ich meine Änderungen an der SIGNALduino.pm und der Firmware gleich in deine Pullrequests committten?

Edit:
Ich lade meine Änderungen jetzt mit in die von dir angelegten Branches, zur Not lässt sich das ja rückgängig machen.

@elektron-bbs
Copy link
Contributor

Dann mache ich mal hier weiter: Welche Punkte sind hier noch offen?

FHEM/00_SIGNALduino.pm Outdated Show resolved Hide resolved
FHEM/00_SIGNALduino.pm Outdated Show resolved Hide resolved
FHEM/00_SIGNALduino.pm Show resolved Hide resolved
@sidey79
Copy link
Contributor Author

sidey79 commented Aug 14, 2023

@elektron-bbs

Ich glaube ich habe meine Kommentare nie abgesendet. Bis auf eines sind alle gelöst, aber ich habe alle noch abgesendet.

@sidey79 sidey79 self-assigned this Aug 15, 2023
@sidey79 sidey79 added the not ASK/OOK alternative modulation compared to the standard label Aug 15, 2023
@sidey79 sidey79 closed this Aug 15, 2023
@sidey79 sidey79 reopened this Aug 15, 2023
@sidey79 sidey79 merged commit 6ef467c into master Aug 15, 2023
25 checks passed
@sidey79 sidey79 deleted the master_freqest branch August 15, 2023 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement not ASK/OOK alternative modulation compared to the standard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants