Bugfix 898

[sidey79]

• Please check if the PR fulfills these requirements

• Tests for the changes have been added / modified (needed for for bug fixes / features)
• commandref has been added / updated (needed for bug fixes / features)
• CHANGED has been updated (needed for bug fixes / features)

• What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Bugfix

• What is the current behavior? (You can also link to an open issue here)

#898

• What is the new behavior (if this is a feature change)?

Sub checks if parameters are provided

• Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

no

• Other information:

[codecov]

Codecov Report

Merging #899 into master will increase coverage by 0.03%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##           master     #899      +/-   ##
==========================================
+ Coverage   54.14%   54.17%   +0.03%     
==========================================
  Files          60       61       +1     
  Lines        7933     7943      +10     
  Branches     1277     1279       +2     
==========================================
+ Hits         4295     4303       +8     
  Misses       2846     2846              
- Partials      792      794       +2     

Flag	Coverage Δ
#fhem	91.37% <ø> (ø)
#modules	91.37% <ø> (ø)
#perl	91.37% <ø> (ø)
#unittest	54.17% <75.00%> (+0.03%)	⬆️
#unittests	91.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
FHEM/00_SIGNALduino.pm	60.84% <25.00%> (-0.07%)	⬇️
.../00_SIGNALduino/01_SIGNALduino_Get_Command_CCReg.t	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9328a20...d6bdd1c. Read the comment docs.

[coveralls]

Pull Request Test Coverage Report for Build 3833

• 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.01%) to 53.68%

---

Totals
Change from base Build 3813:	0.01%
Covered Lines:	3530
Relevant Lines:	6576

---

💛 - Coveralls

[elektron-bbs]

Diese Änderung funktioniert bei mir nicht:

sub SIGNALduino_Get_Command_CCReg {
  my ($hash, @a) = @_;
  my $name=$hash->{NAME};
  Log3 ($hash->{NAME}, 3, "$name: a[0]=$a[0], a[1]=$a[1], $a[2]=$a[2],"); 
	return 'not enough number of arguments' if $#a < 1;	
  return 'Wrong command provided' if $a[0] ne 'ccreg';
  # if (exists($cc1101_register{uc($_[2])}) || $_[2] =~ /^99$/ ) {
  if (exists($cc1101_register{uc($_[1])}) || $_[1] =~ /^99$/ ) {
    return SIGNALduino_Get_Command(@_);
  } else {
   # return "unknown Register $_[2], please choose a valid cc1101 register";
    return "unknown Register $_[1], please choose a valid cc1101 register";
  }
}

Bei "get sduinoIP ccreg 13" erhalte ich:

unknown Register ccreg, please choose a valid cc1101 register

Vorher hat es funktioniert. Ich verwende Version 3.5.0 aus dem Master.

So funktioniert es bei mir wieder:

sub SIGNALduino_Get_Command_CCReg {
  my ($hash, @a) = @_;
  my $name=$hash->{NAME};
  return 'not enough number of arguments' if $#a < 1;	
  return 'Wrong command provided' if $a[0] ne 'ccreg';
  # if (exists($cc1101_register{uc($_[2])}) || $_[2] =~ /^99$/ ) {
  if (exists($cc1101_register{uc($a[1])}) || $a[1] =~ /^99$/ ) {
    return SIGNALduino_Get_Command(@_);
  } else {
   # return "unknown Register $_[2], please choose a valid cc1101 register";
    return "unknown Register $a[1], please choose a valid cc1101 register";
  }
}

[elektron-bbs]

Das erzeugt eine Warnung - besser so:

return 'Wrong command provided' if $a[0] ne 'ccreg';

[sidey79]

Ja da hast Du recht

[sidey79]

So funktioniert es bei mir wieder:

sub SIGNALduino_Get_Command_CCReg {
  my ($hash, @a) = @_;
  my $name=$hash->{NAME};
  return 'not enough number of arguments' if $#a < 1;	
  return 'Wrong command provided' if $a[0] ne 'ccreg';
  # if (exists($cc1101_register{uc($_[2])}) || $_[2] =~ /^99$/ ) {
  if (exists($cc1101_register{uc($a[1])}) || $a[1] =~ /^99$/ ) {
    return SIGNALduino_Get_Command(@_);
  } else {
   # return "unknown Register $_[2], please choose a valid cc1101 register";
    return "unknown Register $a[1], please choose a valid cc1101 register";
  }
}

Was genau möchtest Du mir damit mitteilen?
So recht verstanden, worin der Unterschied zu diesem PR besteht habe ich leider nicht .

[elektron-bbs]

Der Unterschied besteht darin:
$_[1]
in deiner Variante wird:
$a[1]
in meiner.

[sidey79]

Der Unterschied besteht darin:
$_[1]
in deiner Variante wird:
$a[1]
in meiner.

Kannst Du die Zeilennummer referenzieren?
Ich habe da wohl Tomaten auf den Augen .

[elektron-bbs]

Die hier meinte ich. Aber sorry, ich habe mich vertan. Ich hatte bei mir nur die 2 in eine 1 geändert. Hat sich erledigt.