Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

little fix - attr whitelist_IDs #983

Merged
merged 3 commits into from
Jun 20, 2021

Conversation

HomeAutoUser
Copy link
Contributor

  • Please check if the PR fulfills these requirements
  • Tests for the changes have been added / modified (needed for for bug fixes / features)
  • commandref has been added / updated (needed for bug fixes / features)
  • CHANGED has been updated (needed for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Bug fix

  • What is the current behavior? (You can also link to an open issue here)

  • user selects protocols and clicks on "save to whitelist and close" and receives no information on an attribute change
  • a shutdown restart without clicking "Save config" removes the setting
  • What is the new behavior (if this is a feature change)?
  • user receives a change notice to save the changed attributes
  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

  • Other information:

HomeAutoUser and others added 2 commits June 16, 2021 21:34
 * revised save option whitelist_IDs (user see now ? on Save config)
@codecov
Copy link

codecov bot commented Jun 16, 2021

Codecov Report

Merging #983 (5b5e3d2) into master (2737c16) will decrease coverage by 0.00%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #983      +/-   ##
==========================================
- Coverage   58.65%   58.65%   -0.01%     
==========================================
  Files         107      107              
  Lines        8587     8588       +1     
  Branches     1341     1341              
==========================================
  Hits         5037     5037              
- Misses       2638     2639       +1     
  Partials      912      912              
Flag Coverage Δ
fhem 48.66% <33.33%> (-0.01%) ⬇️
modules 58.65% <33.33%> (-0.01%) ⬇️
perl 91.57% <ø> (ø)
unittests 58.65% <33.33%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
FHEM/00_SIGNALduino.pm 62.00% <33.33%> (-0.04%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2737c16...5b5e3d2. Read the comment docs.

@HomeAutoUser
Copy link
Contributor Author

@sidey79 , wenn du ein kühles Päuschen hast ;)

@HomeAutoUser HomeAutoUser merged commit de34765 into RFD-FHEM:master Jun 20, 2021
@HomeAutoUser HomeAutoUser deleted the master_attr branch June 20, 2021 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants