Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IEinterrupt breaks executeIF #41

Closed
jMarcS opened this issue Nov 30, 2012 · 3 comments
Closed

IEinterrupt breaks executeIF #41

jMarcS opened this issue Nov 30, 2012 · 3 comments
Assignees
Labels

Comments

@jMarcS
Copy link
Collaborator

jMarcS commented Nov 30, 2012

From forum user Dave: onGRtouch

He says v01.71 is not catching his onGRtouch, and that it worked okay in 1.70.

What's happening is that his onGRtouch: interrupt starts with an IF. The IfElseStack is not empty -- it has IEinterrupt on it. When executeIF() finds something on the stack, it checks:

if (q != IEexec) {

That needs to be

if ((q != IEexec) && (q != IEinterrupt)) {

otherwise the entire IF block is skipped. In Dave's case, that means it looks like the touch was ignored.

I can make that change easily enough (I have, and it makes Dave's code work again), but I don't know the IF/ELSE code well enough to know if that's all that's needed.

I think it's okay. With other IF/ELSE elements (ELSEIF, ELSE), the IF will already have put its own item on the IfElseStack. The IF is the only one that should have problems.

Paul, does that sound right to you?

@RFO-BASIC
Copy link
Owner

It looks to me like your change will do the trick.

I am going to start a new issue about making intermediate releases.

1 similar comment
@RFO-BASIC
Copy link
Owner

It looks to me like your change will do the trick.

I am going to start a new issue about making intermediate releases.

@ghost ghost assigned jMarcS Nov 30, 2012
jMarcS added a commit to jMarcS/Basic that referenced this issue Nov 30, 2012
@jMarcS
Copy link
Collaborator Author

jMarcS commented Nov 30, 2012

GitHub is a little flaky -- apparently there was a network split last night or this morning. But I think I got it committed and pushed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants