Refactor types for ordering global state in contract history data #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dr-orlovsky
added
refactoring
dr-orlovsky
requested review from
cryptoquick,
crisdut,
nicbus,
zoedberg and
fedsten
crisdut
reviewed
Jul 12, 2023
src/contract/contract.rs
Outdated
| } | ||
|
|
||
| impl WitnessOrd { | ||
| pub fn from_electrum_height(height: u32) -> Self { |
There was a problem hiding this comment.
As we intend to support other explorers, like esplora, I think it's interesting to change this name.
Suggested change
| pub fn from_electrum_height(height: u32) -> Self { | |
| pub fn from_block_height(height: u32) -> Self { |
There was a problem hiding this comment.
Well, it's not block height, it is just an Electrum API which reports 0 for mempool (Bitcoin Core doesn't do that; esplora inherits electrum API). The name MUST indicate that this is something very custom and not a part of anything standard (like block height)
There was a problem hiding this comment.
It could be something like from_explorer_height ?
src/contract/contract.rs
Outdated
| txid, | ||
| } | ||
| } | ||
| pub fn with_electrum_height(height: u32, txid: Txid) -> Self { |
There was a problem hiding this comment.
As we intend to support other explorers, like esplora, I think it's interesting to change this name.
Suggested change
| pub fn with_electrum_height(height: u32, txid: Txid) -> Self { | |
| pub fn with_block_height(height: u32, txid: Txid) -> Self { |
This was referenced Jul 12, 2023
crisdut
previously approved these changes
Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the most minimalistic solution to the problem at the consensus level.
The way it will work is the following: we now guarantee that all 0-heights are considered as the latest updates to the state.
During the validation, all mempool-based global state is ignored (it is not accessible to the VM the same way "mined" global state is; instead VM uses special procedure to access the global state from the currently validated terminal state transition).
For the lightning channel updates (or in any state channels), we do not send or validate consignments - instead, each party constructs state transitions and keeps it OUTSIDE of RGB stash (in LNP node) - alongside history of signatures for bitcoin tx. Thus, these state transitions are never validated with a consensus code/RGB Core.
So I think we should not go further and this is sufficient solution