Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

invoice error for blind with no outpoint #123

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

nicbus
Copy link
Contributor

@nicbus nicbus commented Feb 7, 2024

This PR returns an error instead of silently switching to address-based mode when a blinded invoice is requested (no -a option specified) but no suitable outpoint is found.

The rationale for this is that a user can request a blinded invoice and fail to notice what the command returned is instead an address-based one. This might be the case if, as an example, the wallet had available UTXOs on keychain 0 but not on 9.

Copy link
Member

@dr-orlovsky dr-orlovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK da52d4a

@dr-orlovsky
Copy link
Member

Good improvement, thank you

@dr-orlovsky dr-orlovsky merged commit 9076e4a into RGB-WG:master Feb 8, 2024
18 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants