Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disable codecov comments #228

Merged
merged 1 commit into from
Aug 22, 2018
Merged

disable codecov comments #228

merged 1 commit into from
Aug 22, 2018

Conversation

StrikerRUS
Copy link
Member

No description provided.

@StrikerRUS
Copy link
Member Author

StrikerRUS commented Aug 20, 2018 •
edited
Loading

Things which don't work:

Also, paths have been fixed (https://docs.codecov.io/docs/fixing-paths)

@StrikerRUS StrikerRUS changed the title disable codecov comments [WIP] disable codecov comments Aug 20, 2018
@StrikerRUS StrikerRUS changed the title [WIP] disable codecov comments disable codecov comments Aug 20, 2018
fukatani
fukatani approved these changes Aug 22, 2018
View reviewed changes
Copy link
Member

@fukatani fukatani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@StrikerRUS StrikerRUS merged commit f47000c into master Aug 22, 2018
@StrikerRUS StrikerRUS deleted the codecov branch August 22, 2018 14:23
@StrikerRUS StrikerRUS mentioned this pull request Aug 22, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fukatani fukatani fukatani approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@StrikerRUS @fukatani