Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate from Travis to GitHub Actions and stop testing Python 2 #328

Merged
merged 5 commits into from Feb 5, 2021

Conversation

StrikerRUS
Copy link
Member

@StrikerRUS StrikerRUS commented Jan 31, 2021

Quite big CI refactoring. There are two main changes in this PR:

Also, during refactoring I containerized everything for Linux jobs. It greatly reduces test time and complexity of dependency management.

R-package tests now use the latest available version of R. It is 4.0.3 right now. This is great, I think!

scikit-learn version should be restricted for now because starting from 0.24.0 our integration test fails due to some values in sample-weight array are zeros. I'm going to address this issue in a follow-up PR.

@StrikerRUS
Copy link
Member Author

Oh, forgot to mention that I'm also incrementing macOS version in Python wheel filename according to #309 (comment).

@StrikerRUS
Copy link
Member Author

... And I haven't transferred creating i686 Linux Python wheels. I don't think that they are in demand nowadays.

Copy link
Collaborator

@mlampros mlampros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good work, thanks (especially for the r part of the code)

@fukatani
Copy link
Member

@StrikerRUS
Thank you for PR!

Appveyor was failed.
Could you check this?

@StrikerRUS
Copy link
Member Author

Thanks a lot guys for reviews!

@fukatani

Appveyor was failed.
Could you check this?

Ah yeah, sure! Seems that filename of installer inside zip archive has been changed. I just pushed updates in 4d28d9b. Hope it will make all checks green!

@StrikerRUS
Copy link
Member Author

@fukatani All checks are green now! 👍
Could you please leave your review?

@fukatani
Copy link
Member

fukatani commented Feb 5, 2021

LGTM
Thank you for your contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants