Cleanup policy

[fukatani]

#75

[fukatani]

All tests passed locally, but parallel_grid_search doesn't work well... 😢

[StrikerRUS]

Hi @fukatani !

I remember the same situation when I developed the current implementation of rgf_python to use in parallel code. The short tip: do not rely on (use) __del__ method - you will face with unexpected behavior.

I suggest to add a standalone method to class (transfer code from __del__ to it) which will help user to free resources and will be called by him exactly when needed.

[fukatani]

@StrikerRUS
Thanks for information and suggestion! That's exactly what I needed.

_cleanup is simple and works well, so we can publish it as API instead of new delete method.
How do you think?

[StrikerRUS]

Did you mean _cleanup_partial?

And can you please add the test with something like this?

clf1 = RGFClassifier()
clf2 = RGFClassifier()

clf1.fit(X, y)
clf2.fit(X, y)

clf1.free_data()  # I actually don't know how to name it properly

clf1.predict(X)  # Raises error
clf2.predict(X)  # No error

Also you may bring back _UUIDS.remove(uuid) into the method for speedup (I see you removed this code in the second commit).

[fukatani]

And can you please add the test with something like this?

Good point. This API is used by users, it should be tested.
I checked file deleted by glob.

Also you may bring back _UUIDS.remove(uuid) into the method for speedup (I see you removed this code in the second commit).

Thanks, I implemented it.