Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update #648 implementation to replace noon in Air Rally #650

Merged

Conversation

blank3times
Copy link
Contributor

I have learned my lesson and tested it (looks fine this time). This PR makes it so that 'twilight' goes over 'noon' and not over 'night', changing 'night' back to its old name in Air Rally. Thank you for helping me troubleshoot.

@minenice55
Copy link
Collaborator

already been fixed in cda15b8, closing

@minenice55 minenice55 closed this Jan 22, 2024
@blank3times
Copy link
Contributor Author

blank3times commented Jan 22, 2024

This goes over [cda15b8], which put twilight over night and not over noon. Double Date remains untouched because when you fixed it that looked fine.

already been fixed in cda15b8, closing

@blank3times blank3times changed the title Implement #648 without breaking anything (I think) Update #648 implementation to replace Air Rally noon without breaking anything (I think) Jan 22, 2024
@blank3times blank3times changed the title Update #648 implementation to replace Air Rally noon without breaking anything (I think) Update #648 implementation to replace noon in Air Rally Jan 22, 2024
@minenice55 minenice55 reopened this Jan 22, 2024
@minenice55 minenice55 added this pull request to the merge queue Jan 22, 2024
Merged via the queue into RHeavenStudio:release_1_patches with commit bc90418 Jan 22, 2024
@blank3times blank3times deleted the twilight-over-noon branch January 22, 2024 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants