Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RHPAM-2503]- Console UI - Support for mounting roleMapping and GitHooks #103

Merged
merged 2 commits into from Nov 18, 2019

Conversation

swati-kale
Copy link
Collaborator

Signed-off-by: Swati Kale swkale@redhat.com

@ruromero
Copy link
Member

@swati-kale I think the console should leverage the operator for such complex validations and just render out back to the console the errors coming from the operator.
This is something that is not required right now so IMO just adding the new fields should be enough. They shouldn't be required.

@ruromero
Copy link
Member

If this is too late for this release, ignore my comment. It can be reviewed in the next sprint

@yzhao583
Copy link
Collaborator

Generally looks good to me, if someone can provide more background info, I can provide more detail review thanks.

Signed-off-by: Swati Kale <swkale@redhat.com>
@swati-kale
Copy link
Collaborator Author

swati-kale commented Nov 14, 2019

If this is too late for this release, ignore my comment. It can be reviewed in the next sprint

@ruromero As discussed changed the descriptions and added fieldgroup for RoleMapper.
GitHoooks
RoleMapper

@bmozaffa
Copy link
Contributor

It sounds like this is ready to merge. Let's make sure to test properly before leveraging the commit in the BA operator code.

@bmozaffa bmozaffa merged commit a8b5bbb into RHsyseng:master Nov 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants