[KIECLOUD-322] - Support for EXTENSIONS_IMAGE and EXTENSIONS_IMAGE_NA… #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…MESPACE Signed-off-by: Swati Kale <swkale@redhat.com>
yzhao583
reviewed
Sep 19, 2019
| ]; | ||
|
|
||
| var server; | ||
| var obj = Dot.object(jsonObject); |
There was a problem hiding this comment.
Minor: We may want to change "obj" to something meaningful?
| ) { | ||
| let servers = obj.spec.objects.servers; | ||
|
|
||
| for (server in servers) { |
There was a problem hiding this comment.
We can say "let server in servers" and remove the "var server", and we may use map() here.
Signed-off-by: Swati Kale <swkale@redhat.com>
yzhao583
approved these changes
Sep 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…MESPACE
Signed-off-by: Swati Kale swkale@redhat.com