gnrc_icmpv6_error: don't release orig_pkt on error

The stack might still wants to do something with the packet after copying it to the error message.
RIOT-OS · Nov 16, 2018 · 6ec456b · 6ec456b
1 parent 3b56c78
commit 6ec456b
Showing 1 changed file with 0 additions and 20 deletions.
diff --git a/sys/net/gnrc/network_layer/icmpv6/error/gnrc_icmpv6_error.c b/sys/net/gnrc/network_layer/icmpv6/error/gnrc_icmpv6_error.c
@@ -128,11 +128,6 @@ void gnrc_icmpv6_error_dst_unr_send(uint8_t code, gnrc_pktsnip_t *orig_pkt)
     if (pkt != NULL) {
         gnrc_netapi_send(gnrc_ipv6_pid, pkt);
     }
-#ifdef MODULE_GNRC_PKTBUF
-    gnrc_pktbuf_release_error(orig_pkt, EHOSTUNREACH);
-#else
-    (void)orig_pkt;
-#endif
 }
 
 void gnrc_icmpv6_error_pkt_too_big_send(uint32_t mtu, gnrc_pktsnip_t *orig_pkt)
@@ -142,11 +137,6 @@ void gnrc_icmpv6_error_pkt_too_big_send(uint32_t mtu, gnrc_pktsnip_t *orig_pkt)
     if (pkt != NULL) {
         gnrc_netapi_send(gnrc_ipv6_pid, pkt);
     }
-#ifdef MODULE_GNRC_PKTBUF
-    gnrc_pktbuf_release_error(orig_pkt, EMSGSIZE);
-#else
-    (void)orig_pkt;
-#endif
 }
 
 void gnrc_icmpv6_error_time_exc_send(uint8_t code, gnrc_pktsnip_t *orig_pkt)
@@ -156,11 +146,6 @@ void gnrc_icmpv6_error_time_exc_send(uint8_t code, gnrc_pktsnip_t *orig_pkt)
     if (pkt != NULL) {
         gnrc_netapi_send(gnrc_ipv6_pid, pkt);
     }
-#ifdef MODULE_GNRC_PKTBUF
-    gnrc_pktbuf_release_error(orig_pkt, ETIMEDOUT);
-#else
-    (void)orig_pkt;
-#endif
 }
 
 void gnrc_icmpv6_error_param_prob_send(uint8_t code, void *ptr,
@@ -171,11 +156,6 @@ void gnrc_icmpv6_error_param_prob_send(uint8_t code, void *ptr,
     if (pkt != NULL) {
         gnrc_netapi_send(gnrc_ipv6_pid, pkt);
     }
-#ifdef MODULE_GNRC_PKTBUF
-    gnrc_pktbuf_release_error(orig_pkt, EINVAL);
-#else
-    (void)orig_pkt;
-#endif
 }
 
 /** @} */