Skip to content

Commit

Permalink
riotnode/node: remove _kill_term
Browse files Browse the repository at this point in the history
Remove now unused _kill_term.
  • Loading branch information
cladmi committed Feb 19, 2019
1 parent fae1966 commit 7649520
Showing 1 changed file with 0 additions and 12 deletions.
12 changes: 0 additions & 12 deletions dist/pythonlibs/riotnode/riotnode/node.py
Expand Up @@ -8,7 +8,6 @@
import logging
import subprocess
import contextlib
import signal

import pexpect

Expand Down Expand Up @@ -85,7 +84,6 @@ class RIOTNode():
"""

TERM_SPAWN_CLASS = TermSpawn
TERM_STOP_SIGNAL = signal.SIGKILL
TERM_STARTED_DELAY = int(os.environ.get('RIOT_TERM_START_DELAY') or 3)

MAKE_ARGS = ()
Expand Down Expand Up @@ -179,16 +177,6 @@ def _safe_term_close(self):
# 'make term' is not killed by 'term.close()'
self.logger.critical('Could not close make term')

def _kill_term(self):
"""Kill the current terminal."""
# killpg(SIGKILL) was taken from `testrunner`.
# I do not really like direct `SIGKILL` as it prevents script cleanup.
# I kept it as I do not want to break an edge case that rely on it.

# Using 'killpg' shows that our shell script do not correctly kill
# programs they started. So this is more a hack than a real solution.
os.killpg(os.getpgid(self.term.pid), self.TERM_STOP_SIGNAL)

def make_run(self, targets, *runargs, **runkwargs):
"""Call make `targets` for current RIOTNode context.
Expand Down

0 comments on commit 7649520

Please sign in to comment.