Skip to content

Commit

Permalink
Makefile.include: remove rule to remake PKGs' Makefile.include
Browse files Browse the repository at this point in the history
This rule is not being used, it complicates the makefile and causes
make clean to permform unnecessary actions.

All packages have a Makefile.include, so the rule is not needed anyways.
Also, it is defined with a double colon for no reason.
  • Loading branch information
jcarrano committed Dec 7, 2018
1 parent 35626ed commit 8945a95
Showing 1 changed file with 1 addition and 5 deletions.
6 changes: 1 addition & 5 deletions Makefile.include
Expand Up @@ -357,10 +357,6 @@ include $(RIOTBASE)/sys/Makefile.include
include $(RIOTBASE)/drivers/Makefile.include

# include Makefile.includes for packages in $(USEPKG)
$(RIOTPKG)/%/Makefile.include::
$(Q)"$(MAKE)" -C $(RIOTPKG)/$* Makefile.include

$(USEPKG:%=$(RIOTPKG)/%/Makefile.include): FORCE
-include $(USEPKG:%=$(RIOTPKG)/%/Makefile.include)

# include external modules configuration
Expand Down Expand Up @@ -488,7 +484,7 @@ endef

# The `clean` needs to be serialized before everything else.
ifneq (, $(filter clean, $(MAKECMDGOALS)))
all $(BASELIBS) $(USEPKG:%=$(RIOTPKG)/%/Makefile.include) $(BUILDDEPS) ..in-docker-container: clean
all $(BASELIBS) $(BUILDDEPS) ..in-docker-container: clean
endif

.PHONY: pkg-prepare pkg-build pkg-build-%
Expand Down

0 comments on commit 8945a95

Please sign in to comment.