Skip to content

Commit

Permalink
boards/mips-malta: remove board.
Browse files Browse the repository at this point in the history
The mips-malta board is a maintainance burden, has no working UART input
and is unobtainable and thus must be removed.

1. Unobtainable board
=====================

The mips-malta board is not an off-the-shelf part. A quick web
search only show the MIPS website where one is told to "contact sales".

I could find it on ebay, used, at €155 and from single seller.

Not having access to the board means:

a. We cannot maintain it. In fact it could be broken right now.
b. Potential RIOT uses have not access to the board either. In other
   words, it is pointless to run on hardware nobody has.

2. No working UART input
========================

Not all applications need UART input, but that is no excuse for not supporting
it:

a. Makes development & debugging way harder.
b. It is impossible to run interactive tests.
 b.1. Constrains the rest of the platforms by providing an incentive to not
      make tests interactive.
c. The lack of UART is a witness to the poor quality of the port.

I want to stress point (c). If something as basic as a serial port cannot work,
how can we expect more complex fucntionality to work. The answer is impossible
to know, because of point (1).

3. Maintainance burden
======================

The RIOT project has limited time and human resources which can be better spent.

a. Compiling for mips-malta wastes CPU time.
b. Blacklisting the board in the test wastes contributor's time.
c. Adapting the board's makefile during build system rework takes time and makes
   the reworks harder.
 c.1. Add to that that the changes are most of the time not even tested on the board
      because of (1). Look at the github issues/PRs and you will see it.
d. Developers usually stick to the lowest common denominator. Issue (2) sets this
   denominator unacceptably low.

MIPS platform in general
========================

In commits I will address general issues in the MIPS platform and why it should all
be removed.
  • Loading branch information
jcarrano committed Jul 12, 2019
1 parent 6b094a7 commit ee6b6b9
Show file tree
Hide file tree
Showing 17 changed files with 9 additions and 153 deletions.
3 changes: 0 additions & 3 deletions boards/mips-malta/Makefile

This file was deleted.

4 changes: 0 additions & 4 deletions boards/mips-malta/Makefile.features

This file was deleted.

10 changes: 0 additions & 10 deletions boards/mips-malta/Makefile.include

This file was deleted.

5 changes: 0 additions & 5 deletions boards/mips-malta/doc.txt

This file was deleted.

44 changes: 0 additions & 44 deletions boards/mips-malta/include/board.h

This file was deleted.

41 changes: 0 additions & 41 deletions boards/mips-malta/include/periph_conf.h

This file was deleted.

28 changes: 0 additions & 28 deletions boards/mips-malta/malta.c

This file was deleted.

2 changes: 1 addition & 1 deletion examples/gnrc_border_router/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ BOARD_INSUFFICIENT_MEMORY := airfy-beacon arduino-duemilanove arduino-leonardo \
weio wsn430-v1_3b wsn430-v1_4 yunjia-nrf51822 z1

# The following boards do not have an available UART
BOARD_BLACKLIST += mips-malta pic32-wifire pic32-clicker ruuvitag thingy52
BOARD_BLACKLIST += pic32-wifire pic32-clicker ruuvitag thingy52

# use ethos (ethernet over serial) for network communication and stdio over
# UART, but not on native, as native has a tap interface towards the host.
Expand Down
2 changes: 1 addition & 1 deletion examples/lua_REPL/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ BOARD_INSUFFICIENT_MEMORY := blackpill bluepill calliope-mini cc2650-launchpad \

BOARD_BLACKLIST := arduino-duemilanove arduino-leonardo \
arduino-mega2560 arduino-nano arduino-uno \
chronos hifive1 jiminy-mega256rfr2 mega-xplained mips-malta \
chronos hifive1 jiminy-mega256rfr2 mega-xplained \
msb-430 msb-430h pic32-clicker pic32-wifire telosb \
waspmote-pro wsn430-v1_3b wsn430-v1_4 z1

Expand Down
2 changes: 1 addition & 1 deletion examples/lua_basic/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ BOARD_INSUFFICIENT_MEMORY := blackpill bluepill calliope-mini cc2650-launchpad \
BOARD_BLACKLIST := arduino-duemilanove arduino-leonardo \
arduino-mega2560 arduino-nano \
arduino-uno chronos hifive1 jiminy-mega256rfr2 \
mega-xplained mips-malta msb-430 msb-430h pic32-clicker \
mega-xplained msb-430 msb-430h pic32-clicker \
pic32-wifire telosb waspmote-pro wsn430-v1_3b wsn430-v1_4 z1


Expand Down
3 changes: 0 additions & 3 deletions tests/driver_dynamixel/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,6 @@ BOARD_INSUFFICIENT_MEMORY := arduino-duemilanove arduino-leonardo arduino-nano \
# chronos : USART_1 undeclared
BOARD_BLACKLIST += chronos

# mips-malta : undefined reference to uart_write
BOARD_BLACKLIST += mips-malta

USEMODULE += dynamixel
USEMODULE += shell

Expand Down
3 changes: 0 additions & 3 deletions tests/driver_feetech/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,6 @@ BOARD_INSUFFICIENT_MEMORY := arduino-duemilanove arduino-leonardo arduino-nano \
# chronos : USART_1 undeclared
BOARD_BLACKLIST += chronos

# mips-malta : undefined reference to uart_write
BOARD_BLACKLIST += mips-malta

USEMODULE += feetech
USEMODULE += shell

Expand Down
4 changes: 2 additions & 2 deletions tests/gnrc_ipv6_ext/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@ BOARD_INSUFFICIENT_MEMORY := arduino-duemilanove arduino-leonardo \
nucleo-l053r8 stm32f0discovery stm32l0538-disco \
telosb thingy52 \
waspmote-pro wsn430-v1_3b wsn430-v1_4 z1
# chronos, hamilton, mips-malta, and ruuvitag boards don't support ethos
BOARD_BLACKLIST := chronos hamilton mips-malta ruuvitag
# chronos, hamilton and ruuvitag boards don't support ethos
BOARD_BLACKLIST := chronos hamilton ruuvitag

export TAP ?= tap0

Expand Down
4 changes: 2 additions & 2 deletions tests/gnrc_rpl_srh/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@ BOARD_INSUFFICIENT_MEMORY := arduino-duemilanove arduino-leonardo \
nucleo-l053r8 saml10-xpro saml11-xpro \
stm32f0discovery stm32l0538-disco telosb thingy52 \
waspmote-pro wsn430-v1_3b wsn430-v1_4 z1
# chronos, hamilton mips-malta, and ruuvitag boards don't support ethos
BOARD_BLACKLIST := chronos hamilton mips-malta ruuvitag
# chronos, hamilton and ruuvitag boards don't support ethos
BOARD_BLACKLIST := chronos hamilton ruuvitag

export TAP ?= tap0

Expand Down
4 changes: 2 additions & 2 deletions tests/gnrc_sock_dns/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@ BOARD_INSUFFICIENT_MEMORY := arduino-duemilanove arduino-leonardo \
nucleo-l031k6 stm32f0discovery stm32l0538-disco \
thingy52 telosb \
waspmote-pro wsn430-v1_3b wsn430-v1_4 z1
# chronos, hamilton mips-malta, and ruuvitag boards don't support ethos
BOARD_BLACKLIST := chronos hamilton mips-malta ruuvitag
# chronos, hamilton and ruuvitag boards don't support ethos
BOARD_BLACKLIST := chronos hamilton ruuvitag

export TAP ?= tap0

Expand Down
1 change: 0 additions & 1 deletion tests/pkg_ubasic/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ BOARD_BLACKLIST := \
hifive1 \
jiminy-mega256rfr2 \
mega-xplained \
mips-malta \
msb-430 \
msb-430h \
pic32-clicker \
Expand Down
2 changes: 0 additions & 2 deletions tests/slip/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,6 @@ BOARD_INSUFFICIENT_MEMORY := arduino-duemilanove arduino-leonardo \
nucleo-f303k8 nucleo-f334r8 nucleo-l053r8 \
stm32f0discovery stm32l0538-disco waspmote-pro

BOARD_BLACKLIST += mips-malta

USEMODULE += auto_init_gnrc_netif
USEMODULE += gnrc
USEMODULE += gnrc_pktdump
Expand Down

0 comments on commit ee6b6b9

Please sign in to comment.