-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
boards/Makefile.features: one feature per row #2611
Comments
It seems like an easy fix that with both minimize conflcits and improve readability |
So what boards do you suggest then @haukepetersen ? |
all of them |
list added, see above |
I wanted to tackle this but I noticed PR #2641 already does that but isn't merged,even Travis CI says everything is ok. Any reason for that? |
Probably it was lost in the flood of PRs or the assigned maintainer didn't have time to look into it. |
Most boards list their feature in one or two rows, e.g.:
This leads to conflicts when there are two PR's open simultaneously and both add something to this line. I would actually prefer to have one line per feature, e.g.:
This way there won't be any merge conflicts anymore.
Here is the TODO list:
arduino-mega2560no need, just one featuremsb-430no need, no featuresmsb-430-commonno need, no featuresmsba2-commonno need, no featuresqemu-i386no need, no featuresredbee-econotagno need, just one featuretelosbno need, just one featurewsn430-commonno need, no featuresx86-multiboot-commonno need, no featuresz1no need, just one featureThe text was updated successfully, but these errors were encountered: