Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

boards/Makefile.features: one feature per row #2611

Closed
30 of 40 tasks
haukepetersen opened this issue Mar 16, 2015 · 6 comments · Fixed by #2641
Closed
30 of 40 tasks

boards/Makefile.features: one feature per row #2611

haukepetersen opened this issue Mar 16, 2015 · 6 comments · Fixed by #2641
Assignees
@LudwigKnuepfer
Labels
Community: good first issue This issue is good for newcomers to RIOT to be addressed / implemented Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation

Comments

@haukepetersen
Copy link
Contributor

Most boards list their feature in one or two rows, e.g.:

FEATURES_PROVIDED += periph_uart periph_gpio periph_spi periph_i2c periph_pwm periph_random \
                     periph_adc periph_dac periph_cpuid

This leads to conflicts when there are two PR's open simultaneously and both add something to this line. I would actually prefer to have one line per feature, e.g.:

FEATURES_PROVIDED += periph_uart
FEATURES_PROVIDED += periph_spi
FEATURES_PROVIDED += periph_i2c
FEATURES_PROVIDED += periph_pwm
...

This way there won't be any merge conflicts anymore.

Here is the TODO list:
@haukepetersen haukepetersen added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation Newbie-Task-Candidate labels Mar 16, 2015
@haukepetersen haukepetersen mentioned this issue Mar 16, 2015
Merged
@BigDaddyD
Copy link
Contributor

It seems like an easy fix that with both minimize conflcits and improve readability

@kushalsingh007
Copy link
Member

So what boards do you suggest then @haukepetersen ?

@LudwigKnuepfer
Copy link
Member

all of them

@Tom-VdE Tom-VdE mentioned this issue Mar 16, 2015
Closed
@haukepetersen
Copy link
Contributor Author

list added, see above

@Tom-VdE Tom-VdE mentioned this issue Mar 17, 2015
Closed
@haukepetersen haukepetersen mentioned this issue Mar 18, 2015
Closed
@Tom-VdE Tom-VdE mentioned this issue Mar 18, 2015
Merged
@Darredevil
Copy link
Contributor

I wanted to tackle this but I noticed PR #2641 already does that but isn't merged,even Travis CI says everything is ok. Any reason for that?

@LudwigKnuepfer
Copy link
Member

Probably it was lost in the flood of PRs or the assigned maintainer didn't have time to look into it.

@miri64 miri64 added the Community: good first issue This issue is good for newcomers to RIOT to be addressed / implemented label Sep 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LudwigKnuepfer LudwigKnuepfer

Labels
Community: good first issue This issue is good for newcomers to RIOT to be addressed / implemented Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation
Projects
None yet
Milestone
No milestone
6 participants
@haukepetersen @miri64 @LudwigKnuepfer @BigDaddyD @kushalsingh007 @Darredevil