board: added board nucleo f401 #2601

adamberlinger · 2015-03-15T17:47:33Z

I also added CLOCK_USE_HSI switch to use internal oscillator if required.

haukepetersen · 2015-03-18T12:03:35Z

boards/nucleo-f401/Makefile.features

@@ -0,0 +1,4 @@
+FEATURES_PROVIDED += cpp
+FEATURES_PROVIDED += periph_uart periph_gpio periph_spi periph_i2c periph_pwm \


please put one feature per row (-> see #2611)

haukepetersen · 2015-03-18T15:52:31Z

Hi, looks good! I found some minor things. It seems you have some duplicates in your pin mapping. Could you maybe provide a document similar to this one, as this helps to make sure your pin mapping is clean. Could you also create a Wiki page for the board?

Could you also split this PR and take out the changes done to cpu/stm32f4/startup.c and put them in a separate PR, as these are unrelated to this PR.

adamberlinger · 2015-03-18T20:17:23Z

Hi, thanks for your reply! I will look into it soon and split it. You're right that those pin assignments should not overlap, but it would be also good to have available peripherals mapped to arduino header (which can cause conflicts).
Maybe the best solution would be to allow remapping those pins. E.g. if SPI1_REMAP is defined in Makefile those pins would be remapped. But maybe it is too complicated and confusing.

Is it possible to remove commits done to cpu/stm32f4/startup.c or should I create two new PR (one for CPU and one for borad) and close this one?

haukepetersen · 2015-03-24T12:34:03Z

no, keep this PR open and just remove the cleanup changes you did to the startup.c.

…pplications)

adamberlinger · 2015-03-29T20:17:40Z

Hi, I made some changes in peripheral configuration and removed cleanup changes to startup.c. I also created pinmap spreadsheet here.

haukepetersen · 2015-04-14T18:06:55Z

You still have pin A5 assigned for the boards LED and for SPI0 CLK... I would recommend re-mapping SPI0 CLK to some other pin!

kaspar030 · 2015-04-14T19:59:28Z

@haukepetersen: On the nucleo-f334 that makes the LED blink during transfers - I actually like it. :)

adamberlinger · 2015-05-13T21:42:10Z

Hi, sorry for the delay.
I created wiki page for the board here (I was not sure if I can place it on RIOT wiki since it is not yet merged).
Should I squash all the changes into one commit (or more)?

kaspar030 · 2015-05-15T06:27:48Z

boards/nucleo-f401/board.c

+ * @file
+ * @brief       Board specific implementations for the STM32F4Discovery evaluation board
+ *
+ * @author      Hauke Petersen <hauke.petersen@fu-berlin.de>


copy&paste?

adamberlinger · 2015-05-18T17:40:12Z

Hi,
@kaspar030 thanks for the notice. I updated the copyright headers. Is this alright? Because some parts are copied/derived from STM32F4 Discovery BPS.
I also refactored I2C error handling.
EDIT: I fixed the copyright once more (to include other contributors).

OlegHahm · 2015-08-17T21:41:32Z

@adamberlinger, what's the latest here?

PeterKietzmann · 2015-08-18T06:57:26Z

@katezilla can you please have a look at this PR and if it matches our "new" gpio API and architecture?

katezilla · 2015-08-18T11:55:23Z

yes, checking it

katezilla · 2015-08-18T12:27:19Z

boards/nucleo-f401/include/periph_conf.h

+#define GPIO_2_PORT         GPIOC                   /* Used for user button 1 */
+#define GPIO_2_PIN          3
+#define GPIO_2_CLK          2                       /* 0: PORT A, 1: B ... */
+#define GPIO_2_EXTI_CFG()   (SYSCFG->EXTICR[0] |= SYSCFG_EXTICR1_EXTI3_PC)


in #3095 we changed the implementation and gpio interface. please adapt to that new style, for an example you can check out the stm32f4-discovery board

katezilla · 2015-10-27T18:21:39Z

do you still intend to work on this pr?
otherwise i would like to merge #4119

adamberlinger · 2015-11-02T18:57:26Z

Hi,
sorry for no response in long time. This PR requires some improvements to be compatible with new GPIO API and maybe there are some other issues. If the other PR is ready to be merged, then it probably makes no sense to work on this.

OlegHahm · 2015-11-28T12:04:54Z

@adamberlinger, @katezilla, @haukepetersen, @latsku, anyone object closing this one?

PeterKietzmann · 2015-11-30T07:59:29Z

I'll close this one now in favour of #4119 . @adamberlinger sorry for the duplicate work. Hope to see an other PR from you any time in future :-)

adamberlinger added 4 commits March 15, 2015 15:37

cpu/stm32f4: Added option to run from internal oscillator (HSI)

855ec9b

cpu/stm32f4: Added support for stm32f401

a686f51

board/nucleo-f401: added new board nucleo-f401

737c142

board/nucleo-f401: Remove old code

f5d4da5

OlegHahm added Platform: ARM Platform: This PR/issue effects ARM-based platforms Type: new feature The issue requests / The PR implemements a new feature for RIOT labels Mar 18, 2015

OlegHahm assigned thomaseichinger Mar 18, 2015

haukepetersen reviewed Mar 18, 2015
View reviewed changes

haukepetersen added the CI: needs squashing Commits in this PR need to be squashed; If set, CI systems will mark this PR as unmergable label Mar 18, 2015

adamberlinger added 2 commits March 29, 2015 19:27

board/nucleo-f401: fix white characters + red LED (required by test a…

a4c08bd

…pplications)

board/nucleo-f401: peripheral config

e3e1234

Lotterleben force-pushed the master branch from 1d9f189 to d4e068b Compare March 31, 2015 09:52

OlegHahm force-pushed the master branch 3 times, most recently from 9f184dd to 45554bf Compare March 31, 2015 13:01

board/nucleo-f401: macro refactoring

6f9252d

OlegHahm assigned haukepetersen and unassigned thomaseichinger Apr 9, 2015

OlegHahm modified the milestone: Release 2015.06 Apr 29, 2015

cpu/stm32f4: bug fix in HSI macro

9257e66

kaspar030 reviewed May 15, 2015
View reviewed changes

adamberlinger added 2 commits May 21, 2015 16:45

I2C error handling refactored

ca05ee1

Copyright notice fixed

2a5e3aa

katezilla reviewed Aug 18, 2015
View reviewed changes

OlegHahm modified the milestones: Release 2015.08, Release NEXT MAJOR Sep 2, 2015

latsku mentioned this pull request Oct 26, 2015

boards: Add support for Nucleo-f401 #4119

Merged

OlegHahm removed this from the Release 2015.12 milestone Nov 28, 2015

PeterKietzmann closed this Nov 30, 2015

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

board: added board nucleo f401 #2601

board: added board nucleo f401 #2601

adamberlinger commented Mar 15, 2015

haukepetersen Mar 18, 2015

haukepetersen commented Mar 18, 2015

adamberlinger commented Mar 18, 2015

haukepetersen commented Mar 24, 2015

adamberlinger commented Mar 29, 2015

haukepetersen commented Apr 14, 2015

kaspar030 commented Apr 14, 2015

adamberlinger commented May 13, 2015

kaspar030 May 15, 2015

adamberlinger commented May 18, 2015

OlegHahm commented Aug 17, 2015

PeterKietzmann commented Aug 18, 2015

katezilla commented Aug 18, 2015

katezilla Aug 18, 2015

katezilla commented Oct 27, 2015

adamberlinger commented Nov 2, 2015

OlegHahm commented Nov 28, 2015

PeterKietzmann commented Nov 30, 2015

		@@ -0,0 +1,4 @@
		FEATURES_PROVIDED += cpp
		FEATURES_PROVIDED += periph_uart periph_gpio periph_spi periph_i2c periph_pwm \

board: added board nucleo f401 #2601

board: added board nucleo f401 #2601

Conversation

adamberlinger commented Mar 15, 2015

haukepetersen Mar 18, 2015

Choose a reason for hiding this comment

haukepetersen commented Mar 18, 2015

adamberlinger commented Mar 18, 2015

haukepetersen commented Mar 24, 2015

adamberlinger commented Mar 29, 2015

haukepetersen commented Apr 14, 2015

kaspar030 commented Apr 14, 2015

adamberlinger commented May 13, 2015

kaspar030 May 15, 2015

Choose a reason for hiding this comment

adamberlinger commented May 18, 2015

OlegHahm commented Aug 17, 2015

PeterKietzmann commented Aug 18, 2015

katezilla commented Aug 18, 2015

katezilla Aug 18, 2015

Choose a reason for hiding this comment

katezilla commented Oct 27, 2015

adamberlinger commented Nov 2, 2015

OlegHahm commented Nov 28, 2015

PeterKietzmann commented Nov 30, 2015