Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iotlab-term: make tmux optional #5777

Closed
miri64 opened this issue Aug 29, 2016 · 4 comments
Closed

iotlab-term: make tmux optional #5777

miri64 opened this issue Aug 29, 2016 · 4 comments
Assignees
Labels
Area: tools Area: Supplementary tools Discussion: RFC The issue/PR is used as a discussion starting point about the item of the issue/PR State: stale State: The issue / PR has no activity for >185 days Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation

Comments

@miri64
Copy link
Member

miri64 commented Aug 29, 2016

This issue is two-fold:

  1. I don't really understand the iotlab-term target in Makefile.iotlab anymore since the tmux logging feature was introduced in dist: make: iotlab: add logging to iotlab-term via tmux #5351 (main reason why I can't provide a fix myself). Considering that make term should be the simplest command of all that is a little disquieting.
  2. Not everyone uses tmux and not everyone knows how to use it. The iotlab-* targets should simplify the usage of the IoT-Lab, so adding knowledge about another tool reduces the usability of these targets in my opinion.
@miri64 miri64 added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation Discussion: RFC The issue/PR is used as a discussion starting point about the item of the issue/PR Area: tools Area: Supplementary tools labels Aug 29, 2016
@cgundogan
Copy link
Member

Considering that make term should be the simplest command of all that is a little disquieting.

Why should term be the simplest command? The idea of this makefile is to abstract and hide complex command executions.

Not everyone uses tmux and not everyone knows how to use it.

See https://github.com/RIOT-OS/RIOT/blob/master/dist/testbed-support/README.iotlab.md#iotlab-term

One of the incentives of using the aggregator within tmux is that a user can now de-/attach from a running experiment. This was not possible before. I.e. you can start an experiment without the iotlab-term first, and just attach whenever desired and still see the full output (with or without logging enabled).

If you have discomfort with scrolling (I think we had an offline discussion about this once), then just put setw -g mode-mouse on in your .tmux.conf on the remote server. This could be put into the README as an improvement of the doc, but I don't see why we should drop tmux.

@OlegHahm
Copy link
Member

While I mostly agree with @cgundogan here, I understand @miri64's concerns. How about offering a simple iotlab-term and an advanced iotlab-tmux target (maybe with different names)?

@miri64
Copy link
Member Author

miri64 commented Aug 29, 2016

It's not like I don't know how to handle tmux, but as @OlegHahm states: it hightens the entry bar in my opinion.

@stale
Copy link

stale bot commented Aug 10, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you want me to ignore this issue, please mark it with the "State: don't stale" label. Thank you for your contributions.

@stale stale bot added the State: stale State: The issue / PR has no activity for >185 days label Aug 10, 2019
@stale stale bot closed this as completed Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: tools Area: Supplementary tools Discussion: RFC The issue/PR is used as a discussion starting point about the item of the issue/PR State: stale State: The issue / PR has no activity for >185 days Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation
Projects
None yet
Development

No branches or pull requests

3 participants