byteorder functions in capital letters?

[kaspar030]

RIOT's byteorder.h defines NTOHL() as capital static inline functions. Does anyone remember the reason for not using ntohl() et al?

Like this it is really inconvenient for code also used on other platforms (see kaspar030/sock#2).

[miri64]

@kaspar030 I guess because our coding conventions state that macros should be upper case. For portability you can find the POSIX naming in sys/posix/include/sys/bytes.h ;-)

[miri64]

(which also should help you with portability since the macro is exactly where other OSs would expect it to be <sys/bytes.h>)

[kaspar030]

I guess because our coding conventions state that macros should be upper case.

Well, that's the thing. They are static inline functions, not macros.

[miri64]

See #4812

[kaspar030]

So with the current state of byteorder.h, you don't remember the reason for the function names being uppercase?

[miri64]

Not really, but I guess the HTONS etc. wrapper macros are primarily there for legacy reasons. @Kijewski?

[kaspar030]

the HTONS etc. wrapper macros

They're not macros. :)

[miri64]

That's even more confusing ^^.

[jnohlgard]

I think they were macros at first but were changed into inline functions to make it easier to see programming mistakes.

[kaspar030]

I would propose then, independently of #4812, to change them to use lowercase names. #4812 can then implement the functions using the const macros (or builtins...), and the posix wrapper can just include byteorder.h. What do you think?

[miri64]

Fine by me.

[OlegHahm]

I would suspected that non-RIOT code rather expects these functions to be macros and thus to be uppercase.

[kaspar030]

I would suspected that non-RIOT code rather expects these functions to be macros and thus to be uppercase.

Just checked, in my system headers they are declared as functions.

[OlegHahm]

True.

[miri64]

According to the POSIX-specification they are functions.