gcoap: move dependencies to actual module #7071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kYc0o
added
Type: cleanup
kYc0o
added
the
CI: ready for build
kYc0o
force-pushed
the
gcoap_add_dependencies
branch
from
cf283cc
to
893fcbb
Compare
|
Thanks for the improvement, @kYc0o. I agree that any use of gcoap will need the nanocoap pkg and the gnrc_sock_udp module for the foreseeable future. To make this work complete, please make the same changes for a couple of other make files:
Also, the posix module no longer is required, thanks to #6897, which addressed #5959. If you are comfortable with eliding the posix module in the migration, it works for me. I tested with native and samr21-xpro. |
|
+1 for this PR. @kYc0o any progress? |
|
Sorry, I did't have internet this week-end, I'll work on it ASAP. @kb2ma thanks for your suggestions! I'll include them in this PR. |
kYc0o
force-pushed
the
gcoap_add_dependencies
branch
from
893fcbb
to
bc2387e
Compare
|
Amended and force-pushed. |
miri64
added
Platform: MSP
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By using gcoap a bit I noticed that the actual dependencies for gcoap were declared for the example rather than for the actual module.
As far as I can see, the example doesn't even include
nanocoap.h, which is the main dependency.Thus, this PR proposes to declare such dependencies in Makefile.dep