Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Errorneous Makefile passed Murdock somehow #7741

Closed
miri64 opened this issue Oct 17, 2017 · 3 comments
Closed

CI: Errorneous Makefile passed Murdock somehow #7741

miri64 opened this issue Oct 17, 2017 · 3 comments
Assignees
@kaspar030 @smlng
Labels
Area: CI Area: Continuous Integration of RIOT components Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)

Comments

@miri64
Copy link
Member

miri64 commented Oct 17, 2017

When #7014 was merged its errorneous Makefile somehow got pass all checks and the PR got merged (see #7740).
@miri64 miri64 added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Area: CI Area: Continuous Integration of RIOT components labels Oct 17, 2017
@miri64
Copy link
Member Author

miri64 commented Oct 17, 2017

(searching the log reveals that they did not seem to be build at all...)

@kaspar030
Copy link
Contributor

Seems like murdock's get_jobs stage doesn't fail if one of the makefiles is broken. Will come up with a fix...

@kaspar030 kaspar030 mentioned this issue Oct 17, 2017
Merged
@miri64 miri64 mentioned this issue Oct 18, 2017
Closed
43 tasks
@kaspar030
Copy link
Contributor

Fixed by #7742.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kaspar030 kaspar030

@smlng smlng

Labels
Area: CI Area: Continuous Integration of RIOT components Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@miri64 @kaspar030 @smlng