murdock: fail on broken application Makefile #7742
Conversation
kaspar030
added
Type: bug
kaspar030
added
CI: ready for build
|
Fixes #7741. |
|
Failed correctly: https://ci.riot-os.org/RIOT-OS/RIOT/7742/b87283bf07164cdbf7ab2788e4af6e6d462f0058/output.html I'll remove the test commit. |
kaspar030
removed
the
State: WIP
kaspar030
force-pushed
the
fix_murdock_get_jobs
branch
from
b87283b
to
a59ab07
Compare
| local boards="$(make --no-print-directory -C$appdir info-boards-supported 2>/dev/null || echo broken)" | ||
|
|
||
| if [ "$boards" = broken ]; then | ||
| echo "makefile_broken" |
There was a problem hiding this comment.
Why can't you put out the actual error message? E.g. by piping it to a temporary file or file descriptor instead of /dev/null above?
There was a problem hiding this comment.
Ah I see that the output should go below, but regardless I think it is helpful to print the actual error message.
miri64
added
the
Process: needs backport
There was a problem hiding this comment.
@kaspar030 and I discussed the proposed change offline and my change request does not seem to be that trivial. So let's merge it for now as is and review this at a later time.
@kaspar030 please provide a backport to the 2017.10 branch.
kaspar030
removed
the
Process: needs backport
|
As discussed offline with the release manager, no backport needed. |
A broken application Makefile would error when doing
make -Capp_dir info-boards-supported, but due to the way Murdock called make, that error would just result in empty output.This PR adds the necessary handling.
(includes a test commit to see if this actually works)