Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make: remove MAKEBASE ? #959

Closed
LudwigKnuepfer opened this issue Apr 1, 2014 · 9 comments · Fixed by #963
Closed

make: remove MAKEBASE ? #959

LudwigKnuepfer opened this issue Apr 1, 2014 · 9 comments · Fixed by #963
Labels
Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation Type: question The issue poses a question regarding usage of RIOT

Comments

@LudwigKnuepfer
Copy link
Member

As far as I can see there is no proper case for the variable in the first place and it is being abused as well as not used where it should be as well.

git grep MAKEBASE
Makefile.modules:export MAKEBASE =$(RIOTBASE)
cpu/arm_common/Makefile.include:INCLUDES += -I$(MAKEBASE)/cpu/arm_common/include/
cpu/cc430/Makefile.include:INCLUDES += -I$(MAKEBASE)/cpu/cc430/include/
cpu/lpc1768/Makefile.include:INCLUDES += -I$(MAKEBASE)/cpu/lpc1768/include
cpu/lpc2387/gpioint/Makefile:include $(MAKEBASE)/Makefile.base
cpu/lpc2387/i2c/Makefile:include $(MAKEBASE)/Makefile.base
cpu/lpc2387/mci/Makefile:include $(MAKEBASE)/Makefile.base
cpu/lpc2387/rtc/Makefile:include $(MAKEBASE)/Makefile.base
cpu/mc1322x/Makefile.include:INCLUDES += -I$(MAKEBASE)/cpu/mc1322x/include
cpu/mc1322x/adc/Makefile:include $(MAKEBASE)/Makefile.base
cpu/mc1322x/asm/Makefile:include $(MAKEBASE)/Makefile.base
cpu/mc1322x/maca/Makefile:include $(MAKEBASE)/Makefile.base
cpu/msp430-common/Makefile.include:INCLUDES += -I$(MAKEBASE)/cpu/msp430-common/include/
cpu/native/net/Makefile:include $(MAKEBASE)/Makefile.base
cpu/native/rtc/Makefile:include $(MAKEBASE)/Makefile.base
drivers/cc110x/Makefile:include $(MAKEBASE)/Makefile.base
drivers/cc110x_ng/spi/Makefile:include $(MAKEBASE)/Makefile.base
drivers/lm75a/Makefile:include $(MAKEBASE)/Makefile.base
drivers/ltc4150/Makefile:include $(MAKEBASE)/Makefile.base
drivers/sht11/Makefile:include $(MAKEBASE)/Makefile.base
drivers/srf02/Makefile:include $(MAKEBASE)/Makefile.base
drivers/srf08/Makefile:include $(MAKEBASE)/Makefile.base
sys/transceiver/Makefile:include $(MAKEBASE)/Makefile.base
sys/uart0/Makefile:include $(MAKEBASE)/Makefile.base

git grep 'include $(RIOTBASE)/Makefile.base' | wc -l
74
@LudwigKnuepfer LudwigKnuepfer mentioned this issue Apr 1, 2014
Merged
@Kijewski
Copy link
Contributor

Kijewski commented Apr 1, 2014

+1 burninate the variable.

@LudwigKnuepfer
Copy link
Member Author

My dictionary suggests "urinate" as a correction for "burninate" ;)

@LudwigKnuepfer
Copy link
Member Author

The urban dictionary indicates the meaning encompasses some harmful side effects. I see no harm to be caused as a side effect here.

@Kijewski
Copy link
Contributor

Kijewski commented Apr 1, 2014

"Burninating" just means obliterating. I thought everyone knew Trogdor. :/
http://www.youtube.com/watch?v=7gz1DIIxmEE

@LudwigKnuepfer
Copy link
Member Author

Can't say I did.

@OlegHahm
Copy link
Member

OlegHahm commented Apr 1, 2014

I've never really understood the reason why we have this variable.

@LudwigKnuepfer
Copy link
Member Author

So, you're in favor of its removable I presume?

@OlegHahm
Copy link
Member

OlegHahm commented Apr 1, 2014

I am.

LudwigKnuepfer added a commit to LudwigKnuepfer/RIOT that referenced this issue Apr 1, 2014
@LudwigKnuepfer
make: replace MAKEBASE with RIOTBASE
91814e5 
closes RIOT-OS#959
@LudwigKnuepfer LudwigKnuepfer mentioned this issue Apr 1, 2014
Merged
@LudwigKnuepfer
Copy link
Member Author

This PR removes it: #963

kaspar030 pushed a commit to kaspar030/RIOT that referenced this issue Apr 3, 2014
@LudwigKnuepfer @kaspar030
make: replace MAKEBASE with RIOTBASE
19b8368 
closes RIOT-OS#959
dangnhat pushed a commit to vanhieubk/RIOT that referenced this issue Apr 25, 2014
@LudwigKnuepfer @dangnhat
make: replace MAKEBASE with RIOTBASE
29cdec1 
closes RIOT-OS#959
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation Type: question The issue poses a question regarding usage of RIOT
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

make: replace MAKEBASE with RIOTBASE LudwigKnuepfer/RIOT
3 participants
@Kijewski @OlegHahm @LudwigKnuepfer