boards/nrf52xxxdk: make reset pin work #10072

haukepetersen · 2018-09-28T11:28:49Z

Contribution description

Ever wondered why on most/all of our nrf52dk and nrf52840dk boards the reset pin is not working? Just stumbled upon the doc, where it states that the pin needs to be manually programmed (at least once) to work. This PR does exactly that, and voila, not the reset pins on those boards work like a charm.

Testing procedure

take a nrf52dk or nrf52840dk board where the reset pin is not working
flash any RIOT example on the board
reset the board (do a power-off-on or use make reset, as the changes take one reset cycle to take effect)
enjoy a working reset pin

Issues/PRs references

none

haukepetersen · 2018-09-28T11:52:00Z

Hmm, have spend some more thought on this. Since the config is held in persistent memory, there is not need to check on every system boot.

I will instead provide stand-alone application which provides the means to program the reset pin.

bergzand · 2018-09-28T11:53:32Z

Is it possible to use some GDB magic to write these values (persistently) to the device?

haukepetersen · 2018-09-28T11:59:19Z

have not found anything.

MrKevinWeiss

Tested it on the nrf52dk and works like a charm!

aabadie · 2018-09-28T12:03:46Z

with #9407 and when using openocd, I think the reset pin works

MrKevinWeiss · 2018-09-28T12:05:07Z

boards/common/nrf52xxxdk/board.c

@@ -21,8 +21,46 @@
 #include "cpu.h"
 #include "board.h"

+#if defined(BOARD_NRF52DK)


Why not but the macros in the board.h file?

Or periph_conf.h ?

I think this should be in place that LED0 macros are defined since it is basically a friendly name for a pin.

But it is just for consideration, not trying to push.

Hmm, have spend some more thought on this. Since the config is held in persistent memory, there is not need to check on every system boot.

I will instead provide stand-alone application which provides the means to program the reset pin.

just wait some more minutes :-)

MrKevinWeiss · 2018-09-28T12:05:34Z

boards/common/nrf52xxxdk/board.c

@@ -21,8 +21,46 @@
 #include "cpu.h"
 #include "board.h"

+#if defined(BOARD_NRF52DK)
+#define RESET_PIN       (21U)


Why pin 21 and 18?

This must be hardware related. nrf52832dk board reset is physically connected to P0.21.
Guess its P0.18 for nrf52840dk board.

Ask Nordic why they have chosen them...

This new tool allows configuring the reset pin for nRF52-based boards. As the reset pin configuration is persistent, it does not make sense to include it into the board code...

haukepetersen · 2018-09-28T14:52:28Z

Did rework this PR, now the actual configuration is put in its own tool. So no more runtime or code overhead for the existing board implementations. The tool is also usable for any other board we might stumble upon...

haukepetersen · 2018-10-11T10:40:46Z

@MrKevinWeiss would you mind to take another look? This PR is ready for final review.

MrKevinWeiss · 2018-10-11T10:42:47Z

No problem!

MrKevinWeiss · 2018-10-11T11:23:50Z

Tested on the nrf52dk, on one that had already been programmed and it was able to reset. I then tested it on one that had not been programmed and it worked. I don't have nrf52840dk so I cannot test on it. @haukepetersen can you (or anyone) confirm it works on the nrf52840dk?

Maybe just add tools to the @defgroup in RIOT/doc.txt similar to the utils or something to make travis happy.

haukepetersen · 2018-10-11T12:41:47Z

@MrKevinWeiss I can confirm that the tool works also for nrf52840dk boards.

haukepetersen · 2018-10-11T12:52:27Z

Something is rather broken in the doxygen config, as *.c files should not even be looked at by doxygen, and the tool added here should also not show up in the API docs.

haukepetersen · 2018-10-11T12:54:34Z

strange. Is complaining about a doxygen group in dist/tools/nrf52_resetpin_cfg/main.c, but doxygen should normally a) ignore *.c files, and b) not even parse anything in the dist/* folder of RIOT.

So anyone any idea?!

miri64 · 2018-10-11T12:55:40Z

So anyone any idea?!

Restart build?

aabadie · 2018-10-11T12:58:06Z

It is not doxygen who checks existing groups but hand made shell stuff (based on regexp), that's why.

aabadie · 2018-10-11T13:00:21Z

The best would be to either remove the @ingroup tools or create one somewhere else in a doc.txt.

miri64 · 2018-10-11T13:02:05Z

Or fixing the script ;-)

diff --git a/dist/tools/doccheck/check.sh b/dist/tools/doccheck/check.sh
index 6cd2e6e..d55d3c6 100755
--- a/dist/tools/doccheck/check.sh
+++ b/dist/tools/doccheck/check.sh
@@ -32,7 +32,7 @@ then
 fi
 
 exclude_filter() {
-    grep -v -e vendor -e examples -e tests
+    grep -v -e vendor -e examples -e tests -e dist
 }
 
 # Check all groups are defined

aabadie · 2018-10-11T13:04:51Z

Or fixing the script ;-)

Indeed !

miri64 · 2018-10-11T13:10:30Z

See #10152!

MrKevinWeiss · 2018-10-12T07:36:16Z

Looks good! ACK

haukepetersen · 2018-10-12T07:37:06Z

@miri64 thanks for addressing my issue!

All green -> go.

haukepetersen · 2018-10-12T07:37:44Z

@MrKevinWeiss you beat me by 38 seconds :-)

MrKevinWeiss requested changes Sep 28, 2018

View reviewed changes

MrKevinWeiss reviewed Sep 28, 2018

View reviewed changes

dylad mentioned this pull request Sep 28, 2018

No output in PyTerm after flash #9971

Closed

tools: add nrf52_resetpin_cfg tool

0ca02de

This new tool allows configuring the reset pin for nRF52-based boards. As the reset pin configuration is persistent, it does not make sense to include it into the board code...

haukepetersen force-pushed the fix_nrf52xxxdk_resetpin branch from 2cf1704 to 0ca02de Compare September 28, 2018 14:51

haukepetersen removed the State: WIP State: The PR is still work-in-progress and its code is not in its final presentable form yet label Sep 28, 2018

boards/nrf52xdk: add doc for reset pin config

19d0da0

MrKevinWeiss approved these changes Oct 11, 2018

View reviewed changes

MrKevinWeiss removed the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Oct 11, 2018

haukepetersen added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Oct 11, 2018

miri64 mentioned this pull request Oct 11, 2018

doccheck: exclude dist/tools directory from group check #10152

Merged

miri64 added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Oct 11, 2018

MrKevinWeiss merged commit 0719442 into RIOT-OS:master Oct 12, 2018

haukepetersen deleted the fix_nrf52xxxdk_resetpin branch October 12, 2018 07:37

kkdao mentioned this pull request Feb 6, 2021

Cannot flash turpial-firmware onto Launchpad btcven/turpial-firmware#187

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

boards/nrf52xxxdk: make reset pin work #10072

boards/nrf52xxxdk: make reset pin work #10072

haukepetersen commented Sep 28, 2018

haukepetersen commented Sep 28, 2018

bergzand commented Sep 28, 2018

haukepetersen commented Sep 28, 2018

MrKevinWeiss left a comment •

edited

aabadie commented Sep 28, 2018

MrKevinWeiss Sep 28, 2018

dylad Sep 28, 2018

MrKevinWeiss Sep 28, 2018

MrKevinWeiss Sep 28, 2018

haukepetersen Sep 28, 2018

MrKevinWeiss Sep 28, 2018

dylad Sep 28, 2018

MrKevinWeiss Sep 28, 2018

haukepetersen Sep 28, 2018

haukepetersen commented Sep 28, 2018

haukepetersen commented Oct 11, 2018

MrKevinWeiss commented Oct 11, 2018

MrKevinWeiss commented Oct 11, 2018

haukepetersen commented Oct 11, 2018

haukepetersen commented Oct 11, 2018

haukepetersen commented Oct 11, 2018

miri64 commented Oct 11, 2018

aabadie commented Oct 11, 2018 •

edited

aabadie commented Oct 11, 2018

miri64 commented Oct 11, 2018

aabadie commented Oct 11, 2018

miri64 commented Oct 11, 2018

MrKevinWeiss commented Oct 12, 2018

haukepetersen commented Oct 12, 2018

haukepetersen commented Oct 12, 2018

boards/nrf52xxxdk: make reset pin work #10072

boards/nrf52xxxdk: make reset pin work #10072

Conversation

haukepetersen commented Sep 28, 2018

Contribution description

Testing procedure

Issues/PRs references

haukepetersen commented Sep 28, 2018

bergzand commented Sep 28, 2018

haukepetersen commented Sep 28, 2018

MrKevinWeiss left a comment • edited

Choose a reason for hiding this comment

aabadie commented Sep 28, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

haukepetersen commented Sep 28, 2018

haukepetersen commented Oct 11, 2018

MrKevinWeiss commented Oct 11, 2018

MrKevinWeiss commented Oct 11, 2018

haukepetersen commented Oct 11, 2018

haukepetersen commented Oct 11, 2018

haukepetersen commented Oct 11, 2018

miri64 commented Oct 11, 2018

aabadie commented Oct 11, 2018 • edited

aabadie commented Oct 11, 2018

miri64 commented Oct 11, 2018

aabadie commented Oct 11, 2018

miri64 commented Oct 11, 2018

MrKevinWeiss commented Oct 12, 2018

haukepetersen commented Oct 12, 2018

haukepetersen commented Oct 12, 2018

MrKevinWeiss left a comment •

edited

aabadie commented Oct 11, 2018 •

edited