Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sys/auto_init: Fixed initialization of sht1x [backport 2018.10] #10289

Merged
merged 2 commits into from Nov 5, 2018
Merged

sys/auto_init: Fixed initialization of sht1x [backport 2018.10] #10289

merged 2 commits into from Nov 5, 2018

Conversation

maribu
Copy link
Member

@maribu maribu commented Oct 29, 2018 •
edited by jia200x

Backport of #10267

Contribution description

Commit cef81a1 introduced two bugs:

  • the driver for sht1x is initialized two times
  • the second initialization is done only when SAUL is used, but sht1x needs
    to be initialized in any case. (SAUL registration is also done there, but
    only when SAUL is actually being used.)

This commit fixes both.

Testing procedure

E.g. use examples/default on a board that features an SHT1x sensor, e.g. the MSB-A2. Prior to this PR RIOT will not boot due to the double initialization, with this PR applied RIOT will boot again.

@maribu
sys/auto_init: Fixed initialization of sht1x
6d9bd87 
 - the driver for sht1x is initialized two times
 - the second initialization is done only when SAUL is used, but sht1x needs
   to be initialized in any case. (SAUL registration is also done there, but
   only when SAUL is actually being used.)

This commit fixes both.
@maribu
sys/auto_init: Improved doc on sht1x auto init
da84d10 
The auto initialization of the sht1x module differs from the initialization of
other sensors, but previously no documentation pointed that out. This lack of
documentation led to a bug being introduced. This commit provides the previously
missing documentation.
@maribu maribu changed the title Autoinit fix backportAutoinit fix backport (backport) sys/auto_init: Fixed initialization of sht1x (backport) Oct 29, 2018
@jia200x jia200x added the Process: release backport Integration Process: The PR is a release backport of a change previously provided to master label Nov 2, 2018
@jia200x jia200x changed the title sys/auto_init: Fixed initialization of sht1x (backport) sys/auto_init: Fixed initialization of sht1x [backport 2018.10] Nov 2, 2018
@jia200x
Copy link
Member

jia200x commented Nov 2, 2018 •
edited

(I updated the title)... and description

@jia200x jia200x added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Nov 2, 2018
@jia200x
Copy link
Member

jia200x commented Nov 2, 2018

looks ok (commits are the same)

@jia200x jia200x added Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines labels Nov 2, 2018
@jia200x
Copy link
Member

jia200x commented Nov 2, 2018 •
edited 

/tmp/dwq.0.2589684507658072/e8222e3065d9e394cc9f3182714c63e5/tests/pkg_libhydrogen/../../Makefile.include:557: recipe for target 'test' failed
make: *** [test] Error 1
make: Leaving directory '/tmp/dwq.0.2589684507658072/e8222e3065d9e394cc9f3182714c63e5/tests/pkg_libhydrogen

@cladmi have you seen this before? I've been getting this error lately. It's triggered randomly :/

@jia200x jia200x added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Nov 2, 2018
jia200x
jia200x approved these changes Nov 2, 2018
View reviewed changes
Copy link
Member

@jia200x jia200x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

untested ACK

@jia200x jia200x merged commit 6ed45a6 into RIOT-OS:master Nov 5, 2018
@maribu maribu deleted the autoinit_fix_backport branch November 5, 2018 12:33
@jia200x
Copy link
Member

jia200x commented Nov 5, 2018

this was against master. I will cherry pick and open another PR against 2018.10-branch.

@jia200x jia200x mentioned this pull request Nov 5, 2018
Merged
@cladmi
Copy link
Contributor

cladmi commented Nov 5, 2018 

/tmp/dwq.0.2589684507658072/e8222e3065d9e394cc9f3182714c63e5/tests/pkg_libhydrogen/../../Makefile.include:557: recipe for target 'test' failed
make: *** [test] Error 1
make: Leaving directory '/tmp/dwq.0.2589684507658072/e8222e3065d9e394cc9f3182714c63e5/tests/pkg_libhydrogen

@cladmi have you seen this before? I've been getting this error lately. It's triggered randomly :/

That just looks like the test that failed. It would be easier to debug with the previous output.

@jia200x
Copy link
Member

jia200x commented Nov 5, 2018

That just looks like the test that failed. It would be easier to debug with the previous output.

It has appeared in several PRs. Even with doc changes :/

@jia200x jia200x added this to the Release 2018.10 milestone Nov 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jia200x jia200x jia200x approved these changes

Assignees
No one assigned
Labels
CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Process: release backport Integration Process: The PR is a release backport of a change previously provided to master Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines
Projects
None yet
Milestone
Release 2018.10
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@maribu @jia200x @cladmi