Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gnrc_ipv6_nib: fix several issues found with LLVM's static code analyzer (only critical) [backport 2018.10] #10359

Conversation

miri64
Copy link
Member

@miri64 miri64 commented Nov 9, 2018

Backport of #10358

Contribution description

This takes out the most critical fixes out of #10350.

Testing procedure

Execute make -C examples/gnrc_networking scan-build. It should pass. For functionality tests I recommend to use the a subset of the tests outlined in the release specifications.

Issues/PRs references

Contains parts of #10350 but can be merged independently.

@miri64 miri64 added Area: network Area: Networking CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Process: release backport Integration Process: The PR is a release backport of a change previously provided to master Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) labels Nov 9, 2018
@miri64 miri64 added this to the Release 2018.10 milestone Nov 9, 2018
Copy link
Member

@jia200x jia200x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commits are the same into 2018.10-branch. ACK. Let's wait for Murdock

@miri64 miri64 merged commit f30924a into RIOT-OS:2018.10-branch Nov 9, 2018
@miri64 miri64 deleted the backport/2018.10/gnrc/fix/llvm-static-analyzer2 branch November 9, 2018 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: network Area: Networking CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Process: release backport Integration Process: The PR is a release backport of a change previously provided to master Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants