Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

boards/frdm-kw41z: autoload fxos8700 with saul_default #10408

Merged
merged 1 commit into from Nov 17, 2018
Merged

boards/frdm-kw41z: autoload fxos8700 with saul_default #10408

merged 1 commit into from Nov 17, 2018

Conversation

aabadie
Copy link
Contributor

@aabadie aabadie commented Nov 16, 2018

Contribution description

This is a small update of the frdm-kw41z boards: it adds the fxos8700 module to the default loaded modules when saul is loaded.

This way the accelerometer values are available from saul in the default application.

Testing procedure

Just build and flash the examples/default application for frdm-kw41z and verify the fxos8700 values can be read:

$ make BOARD=frdm-kw41z -C examples/default flash term

Issues/PRs references

None

@aabadie aabadie added Area: drivers Area: Device drivers CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Area: boards Area: Board ports Area: SAUL Area: Sensor/Actuator Uber Layer labels Nov 16, 2018
jnohlgard
jnohlgard approved these changes Nov 16, 2018
View reviewed changes
Copy link
Member

@jnohlgard jnohlgard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on frdm-kw41z using examples/default. saul read all shows the accelerometer values in the list now, does not show them on master

@jnohlgard jnohlgard added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Nov 17, 2018
@jnohlgard jnohlgard added this to the Release 2019.01 milestone Nov 17, 2018
@jnohlgard jnohlgard added Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines labels Nov 17, 2018
@jnohlgard jnohlgard merged commit c5ebf60 into RIOT-OS:master Nov 17, 2018
@aabadie aabadie deleted the pr/board/frdm-kw41z-auto-fxos8700 branch December 8, 2018 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnohlgard jnohlgard jnohlgard approved these changes

Assignees
No one assigned
Labels
Area: boards Area: Board ports Area: drivers Area: Device drivers Area: SAUL Area: Sensor/Actuator Uber Layer CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation
Projects
None yet
Milestone
Release 2019.01
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aabadie @jnohlgard