Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/nimble: Add ble_hs_stop.c to makefile #10450

Closed

Conversation

ccollins476ad
Copy link

Contribution description

This file (ble_hs_stop.c) was added to NimBLE in this PR: apache/mynewt-nimble#216. This PR adds an entry for this file to the pkg/nimble/nimble.host.mk Makefile.

Without this change, an attempt to build the nimble package fails with a linker error, as seen here: https://travis-ci.org/apache/mynewt-nimble/jobs/458153788

Testing procedure

Simply ensure the nimble_gatt example builds, e.g.,

cd examples/nimble_gatt && make

Issues/PRs references

This file was added to NimBLE in this PR:
apache/mynewt-nimble#216
@kaspar030 kaspar030 added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Area: BLE Area: Bluetooth Low Energy support labels Nov 21, 2018
@kaspar030
Copy link
Contributor

@ccollins476ad welcome to the RIOT community and thanks for your contribution!

The nimble commit currently linked in pkg/nimble/Makefile doesn't include this file. I guess the fix would be necessary when bumping the nimble version?

@ccollins476ad
Copy link
Author

Thanks, @kaspar030. I am not especially familiar with RIOT. It seems I should have done a bit more research before submitting this PR! The failing Travis jobs in the nimble repo were the motivation for this PR. I was a bit surprised that a change to a foreign repo (nimble) could break RIOT; it seems I should have followed up on this suspicion.

The Murdock job for this PR is failing because it can't find ble_hs_stop.c, which makes sense in light of your comment above. I think it makes the most sense if I close this PR and investigate the proper way to fix the nimble travis failures.

Thanks again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: BLE Area: Bluetooth Low Energy support CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants