Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg: openwsn: update with iot-lab_M3 support and split patch files #1056

Merged
merged 1 commit into from
May 14, 2014

Conversation

thomaseichinger
Copy link
Member

@thomaseichinger thomaseichinger added this to the Release 2014.04 milestone Apr 25, 2014
@Kijewski
Copy link
Contributor

Files changed: 155
Lines changed: +19,217 −38,440
Duuuude!!

How can anyone but you keep this pkg up to date in the future?

@thomaseichinger
Copy link
Member Author

😄 as you see, already reduced changed lines to half.
Further reductions are in the pipeline (eliminating HW specific dependencies) but wont make it into this release.
Most changes are dedicated to the fact that OpenWSN throws lots of warnings with our compiler flags and compiles now warning free. Hope to get most of those into OpenWSN upstream though.

@thomaseichinger
Copy link
Member Author

updated addressing @LudwigOrtmann's in person comment to remove $(BOARDINCLUDE) $(PROJECTINCLUDE) $(CPUINCLUDE) from Makefiles

@OlegHahm
Copy link
Member

Shouldn't the first two commits be squashed? (Since they won't work separately.)

@thomaseichinger
Copy link
Member Author

yes, they will be squashed but wanted to provide the possibility to review without the patch files obfuscating all the other changes.

@OlegHahm
Copy link
Member

I see. In this case: ACK, squash, and merge at will.

@thomaseichinger
Copy link
Member Author

squashed and GO

thomaseichinger added a commit that referenced this pull request May 14, 2014
pkg: openwsn: update with iot-lab_M3 support and split patch files
@thomaseichinger thomaseichinger merged commit e8e7f3a into RIOT-OS:master May 14, 2014
@thomaseichinger thomaseichinger deleted the pkg-openwsn branch May 14, 2014 13:11
@thomaseichinger thomaseichinger restored the pkg-openwsn branch May 11, 2017 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: needs squashing Commits in this PR need to be squashed; If set, CI systems will mark this PR as unmergable Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants