Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cpu/esp8266: added/changed helper functions #10655

Merged
merged 3 commits into from May 24, 2019
Merged

cpu/esp8266: added/changed helper functions #10655

merged 3 commits into from May 24, 2019

Conversation

gschorcht
Copy link
Contributor

@gschorcht gschorcht commented Dec 26, 2018 •
edited

Contribution description

This PR contains

  • a new helper function print_meminfo that can be used for debugging memory usage in ESP8266. Before, there were several modules with the same code for printing the memory usage. To avoid further code duplication, the new function printf_meminfo was introduced.
  • a change of printf format identifiers since the ets_printf ROM function does not support h format identifier.
  • a fix of missing spaces in esp_hexdump helper function

Testing procedure

Since the PR does not contain changes of functionality, successful compilation is the test.

Issues/PRs references

This PR is prerequisite for further upcoming PRs. The references to this PRs will be updated.

@gschorcht gschorcht added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation Platform: ESP Platform: This PR/issue effects ESP-based platforms Area: cpu Area: CPU/MCU ports labels Dec 26, 2018
@gschorcht gschorcht mentioned this pull request Dec 27, 2018
Merged
@aabadie aabadie added this to the Release 2019.01 milestone Dec 28, 2018
@smlng smlng added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label May 22, 2019
@smlng smlng self-assigned this May 22, 2019
smlng
smlng approved these changes May 22, 2019
View reviewed changes
Copy link
Member

@smlng smlng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, if CI agrees this is good to go

@smlng
Copy link
Member

smlng commented May 22, 2019

please rebase

@smlng smlng added Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines labels May 22, 2019
@gschorcht
cpu/esp8266: fix of esp_hexdump function
46ea36f 
A space was mission after each field.
@gschorcht
cpu/esp8266: fix of printf format identifiers
501d679 
Format identifier `h` and `hh` removed since `esp_printf` does not support them.
@gschorcht
cpu/esp8266: print_meminfo function added
2c555a7
@gschorcht
Copy link
Contributor Author

@smlng Thanks for reviewing. Rebased.

@smlng smlng merged commit 2465b33 into RIOT-OS:master May 24, 2019
@gschorcht gschorcht deleted the esp8266_tools_changes branch May 24, 2019 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smlng smlng smlng approved these changes

Assignees

@smlng smlng

Labels
Area: cpu Area: CPU/MCU ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: ESP Platform: This PR/issue effects ESP-based platforms Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation
Projects
None yet
Milestone
Release 2019.07
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gschorcht @smlng @miri64 @aabadie