Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boards: slwstk6220a: remove support (so it can be replaced) #10685

Merged
merged 4 commits into from
Oct 26, 2020

Conversation

basilfx
Copy link
Member

@basilfx basilfx commented Dec 31, 2018

Contribution description

This PR removes support for the stand-alone version of the SLWSTK6220a, so that it can be replaced by the EFM32 port.

After this gets merged, LOSTANDFOUND.md will be updated via separate PR, then another PR will be opened to add support using the EFM32 port. Then, there will be no two different EFM32 ports anymore.

Although it will be replaced, I think it's a good idea to list it in LOSTANDFOUND.md to highlight the stand-alone version.

Testing procedure

Confirm that it is removed and everything builds.

Issues/PRs references

None.

@basilfx basilfx added Platform: ARM Platform: This PR/issue effects ARM-based platforms CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Area: boards Area: Board ports labels Dec 31, 2018
@PeterKietzmann PeterKietzmann added the Community: Hack'n'ACK candidate This PR is a candidate for review and discussion during one of RIOT's monthly Hack'n'ACK parties label Mar 5, 2019
@PeterKietzmann
Copy link
Member

@basilfx I have absolutely no idea about the status of EFM32 or what slwstk6220a is :-) but I assume this PR could be easily merged, right? Can you give a quick update on the current situation in RIOT?

@basilfx basilfx force-pushed the feature/efm32_remove_slwstk6220a branch from e635b94 to d1f221d Compare May 28, 2019 18:12
@basilfx
Copy link
Member Author

basilfx commented May 28, 2019

I dont know the state of the slwstk6220a. I don't own this board, so never tested it :-) But I think the new port is more superior, and at least contains all the features of this port.

I've rebased this PR.

@PeterKietzmann
Copy link
Member

@basilfx now after some time has passed I think it might be a good idea to have the changes for re-integrating SLWSTK6220a directly available before removing it. What do you think? However, reintegration needs to be tested and I still don't have the hardware so we would need to find someone (maybe @haukepetersen as the initial author) to test it then.

@basilfx
Copy link
Member Author

basilfx commented Jul 30, 2019

That's fine with me. I once talked to @haukepetersen and understood he had three SLWSTK6220a boards, and could send me one :-)

@basilfx basilfx force-pushed the feature/efm32_remove_slwstk6220a branch from d1f221d to 0c27990 Compare September 24, 2019 16:36
@stale
Copy link

stale bot commented Mar 27, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you want me to ignore this issue, please mark it with the "State: don't stale" label. Thank you for your contributions.

@stale stale bot added the State: stale State: The issue / PR has no activity for >185 days label Mar 27, 2020
@tcschmidt
Copy link
Member

Is this ready for testing @haukepetersen ?

@stale stale bot removed the State: stale State: The issue / PR has no activity for >185 days label Apr 1, 2020
@stale
Copy link

stale bot commented Oct 3, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you want me to ignore this issue, please mark it with the "State: don't stale" label. Thank you for your contributions.

@stale stale bot added the State: stale State: The issue / PR has no activity for >185 days label Oct 3, 2020
@basilfx basilfx force-pushed the feature/efm32_remove_slwstk6220a branch from 0c27990 to e8935ab Compare October 20, 2020 20:55
@stale stale bot removed State: stale State: The issue / PR has no activity for >185 days labels Oct 20, 2020
@basilfx
Copy link
Member Author

basilfx commented Oct 20, 2020

Rebased this PR. Should still be an easy one to merge.

@benpicco
Copy link
Contributor

benpicco commented Oct 20, 2020

I take https://github.com/basilfx/EFM2RIOT/tree/develop will bring the replacement?

Copy link
Contributor

@benpicco benpicco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking forward for the version from EFM2RIOT along with it's siblings.

That one only needs to be adapted to the latest Kconfig changes.

@basilfx basilfx force-pushed the feature/efm32_remove_slwstk6220a branch 2 times, most recently from 4fdb639 to 685e88b Compare October 26, 2020 18:37
@basilfx basilfx force-pushed the feature/efm32_remove_slwstk6220a branch from 685e88b to fdd4671 Compare October 26, 2020 18:42
@basilfx basilfx requested a review from miri64 as a code owner October 26, 2020 18:42
@benpicco benpicco merged commit cab1ea6 into RIOT-OS:master Oct 26, 2020
@basilfx basilfx deleted the feature/efm32_remove_slwstk6220a branch October 26, 2020 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: boards Area: Board ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Community: Hack'n'ACK candidate This PR is a candidate for review and discussion during one of RIOT's monthly Hack'n'ACK parties Platform: ARM Platform: This PR/issue effects ARM-based platforms
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants