-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
boards: slwstk6220a: remove support (so it can be replaced) #10685
boards: slwstk6220a: remove support (so it can be replaced) #10685
Conversation
@basilfx I have absolutely no idea about the status of EFM32 or what slwstk6220a is :-) but I assume this PR could be easily merged, right? Can you give a quick update on the current situation in RIOT? |
e635b94
to
d1f221d
Compare
I dont know the state of the I've rebased this PR. |
@basilfx now after some time has passed I think it might be a good idea to have the changes for re-integrating SLWSTK6220a directly available before removing it. What do you think? However, reintegration needs to be tested and I still don't have the hardware so we would need to find someone (maybe @haukepetersen as the initial author) to test it then. |
That's fine with me. I once talked to @haukepetersen and understood he had three SLWSTK6220a boards, and could send me one :-) |
d1f221d
to
0c27990
Compare
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you want me to ignore this issue, please mark it with the "State: don't stale" label. Thank you for your contributions. |
Is this ready for testing @haukepetersen ? |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you want me to ignore this issue, please mark it with the "State: don't stale" label. Thank you for your contributions. |
0c27990
to
e8935ab
Compare
Rebased this PR. Should still be an easy one to merge. |
I take https://github.com/basilfx/EFM2RIOT/tree/develop will bring the replacement? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking forward for the version from EFM2RIOT along with it's siblings.
That one only needs to be adapted to the latest Kconfig changes.
4fdb639
to
685e88b
Compare
685e88b
to
fdd4671
Compare
Contribution description
This PR removes support for the stand-alone version of the SLWSTK6220a, so that it can be replaced by the EFM32 port.
After this gets merged, LOSTANDFOUND.md will be updated via separate PR, then another PR will be opened to add support using the EFM32 port. Then, there will be no two different EFM32 ports anymore.
Although it will be replaced, I think it's a good idea to list it in LOSTANDFOUND.md to highlight the stand-alone version.
Testing procedure
Confirm that it is removed and everything builds.
Issues/PRs references
None.