gnrc_ipv6_nib: fix RA reception for non-6LN interfaces #10724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miri64
added
Type: bug
6 tasks
|
Tested with my ESP border router. |
gschorcht
added
the
CI: ready for build
When having a non-6LN interface and a 6LN interface (e.g. on a border router) the assertion can hit when a Router Advertisement is received. This makes the check an `if` statement rather than an assertion, to account for that case. Co-authored-by: Gunar Schorcht <gunar@schorcht.net>
miri64
force-pushed
the
gnrc_ipv6_nib/fix/mixed-mode-ABRO
branch
from
739f5f2
to
1f71b30
Compare
|
Fixed and amended fixes directly for bugs pointed out by Murdock. |
|
@gschorcht good to merge? |
|
Thanks |
|
Thank you for the review :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
When having a non-6LN interface and a 6LN interface (e.g. on a border
router) the assertion can hit when a Router Advertisement is received.
This makes the check an
ifstatement rather than an assertion, toaccount for that case.
Testing procedure
Run a border router (e.g. with ESP-now where this problem arose). It now should not hit an assertion anymore. For non-border-routers the operation should still resume as normal.
Issues/PRs references
See #10524 (comment)