gnrc_sixlowpan_frag: remove redundant PID member #11015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miri64
added
Area: network
smlng
requested changes
Feb 15, 2019
| @@ -89,10 +89,9 @@ typedef struct { | |||
| */ | |||
| typedef struct { | |||
| gnrc_pktsnip_t *pkt; /**< Pointer to the IPv6 packet to be fragmented */ | |||
| size_t datagram_size; /**< Length of just the (uncompressed) IPv6 packet to be fragmented */ | |||
| uint16_t datagram_size; /**< Length of just the (uncompressed) IPv6 packet to be fragmented */ | |||
There was a problem hiding this comment.
unrelated, or at least a second commit?
There was a problem hiding this comment.
Split out in its own commit.
The interface ID is actually also provided in `pkt` so providing it in the `gnrc_sixlowpan_msg_frag_t` struct is redundant.
It can't get bigger, so it doesn't make sense to waste another 2 byte on it.
miri64
force-pushed
the
gnrc_sixlowpan_frag/enh/rm-pid
branch
from
a261a2d
to
0954fab
Compare
smlng
approved these changes
Feb 15, 2019
smlng
added
Reviewed: 1-fundamentals
|
Murdock's also happy :-) |
|
Since I'm about to open a PR with another modification to |
(see #11021) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
The interface ID is actually also provided in
pktso providing it in thegnrc_sixlowpan_msg_frag_tstruct is redundant.Testing procedure
examples/gnrc_networkingon a 6Lo-compatible board (e.g.iotlab-m3,samr21-xpro, etc.) should still be able to ping with large payloads (e.g. >100) to a node flashed withexamples/gnrc_border_router(link-local addresses is enough).Issues/PRs references
None.