Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

isrpipe: split isrpipe_read_timeout to isolate xtimer dependency #11267

Merged
merged 2 commits into from
Mar 26, 2019
Merged

isrpipe: split isrpipe_read_timeout to isolate xtimer dependency #11267

merged 2 commits into from
Mar 26, 2019

Commits on Mar 26, 2019

  1. isrpipe: split isrpipe_read_timeout to isolate xtimer dependency 

    This defines a new 'isrpipe_read_timeout' module that should be used when using
the timeout based function of isrpipe.

This fix the implicit dependency to 'xtimer' that is only needed for the
'_timeout' functions.

It prevents 'stdio_uart' that uses 'isrpipe' to need to depend on xtimer.
This was silently solved at link time for most platforms but not for the
'esp32' for example.

'drivers/at' needed to be updated at the same time to follow the api change.
    @cladmi
    cladmi committed Mar 26, 2019
    Configuration menu
    Copy the full SHA
    b07eecd View commit details
    Browse the repository at this point in the history

  2. drivers/at: remove the direct dependency to xtimer 

    `at` is not using the `xtimer` module directly but only through
'isrpipe_read_timeout'.
    @cladmi
    cladmi committed Mar 26, 2019
    Configuration menu
    Copy the full SHA
    29fc58b View commit details
    Browse the repository at this point in the history