pkg/tinydtls: Update repository URL to new location, fix posix_sockets #11277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When WITH_RIOT_GNRC is set in CFLAGS, tinydtls will use a more compact address representation based on ipv6_addr_t instead of POSIX-style sockaddr_in6 to identify sessions (cf. struct session_t). When posix_sockets are used (as in libcoap, e.g.), the POSIX address representation should be selected automatically for consistency. This change adds -DWITH_RIOT_GNRC to CFLAGS only when the module posix_sockets is not selected.
leandrolanzieri
requested changes
Mar 26, 2019
There was a problem hiding this comment.
I'm getting the following error while building the dtls-echo example application on native:
RIOT/examples/dtls-echo/bin/pkg/native/tinydtls/session.h:96:53: error: unknown type name ‘socklen_t’
struct sockaddr* dtls_session_addr(session_t *sess, socklen_t *addrlen);
leandrolanzieri
added
the
Reviewed: 1-fundamentals
[tinydtls] Makefile: Updated PKG_URL The tinydtls repository has moved from Eclipse Gerrit to GitHub [1]. PKG_URL now points to the new direction and PKG_VERSION was updated to the HEAD of the develop branch. [1] https://github.com/eclipse/tinydtls.git
Sorry, I did not re-test the dtls-echo example for a while. This should work now. |
leandrolanzieri
added
Reviewed: 2-code-design
leandrolanzieri
approved these changes
Mar 28, 2019
|
And go |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tinydtls has moved its source repository to GitHub. This change therefore updates the
PKG_URLfor package tinydtls and thePKG_VERSIONto the HEAD of the development branch. (Note that there is no official stable release for tinydtls yet and the development branch contains the entire RIOT support.)The second change in this PR fixes the configuration for
posix_socketsas the existing CFLAGS-based method did not work.