Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Esp32 documentation fixes #11375

Merged
merged 2 commits into from Apr 12, 2019
Merged

Conversation

yegorich
Copy link
Contributor

Contribution description

Fix ENC28J60 configuration example and mark CAN as supported for ESP32 platform.

Testing procedure

make doc and look at the esp32-wroom-32 board documentation.

Add missing '#' to the MODULE_ENC28J80's endif.

Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
CAN interface is now supported in RIOT. Change feature tables
accordingly.

Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
@MrKevinWeiss MrKevinWeiss added Area: doc Area: Documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer labels Apr 11, 2019
Copy link
Contributor

@gschorcht gschorcht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes make sense.

@gschorcht
Copy link
Contributor

gschorcht commented Apr 12, 2019

@yegorich Thank you for changing it.

@gschorcht gschorcht merged commit 86fa644 into RIOT-OS:master Apr 12, 2019
@yegorich yegorich deleted the esp32-documentation-fixes branch April 12, 2019 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: doc Area: Documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants