tools/compile_and_test_for_board: assert resultdir is valid

dist/tools/compile_and_test_for_board/compile_and_test_for_board.py

@@ -190,6 +190,24 @@ def create_directory(directory, clean=False, mode=0o755):
     os.makedirs(directory, mode=mode, exist_ok=True)
 
 
+def is_in_directory(path, directory):
+    """Return if `path` is inside `directory`.
+
+    >>> is_in_directory('RIOT/a/b/c', 'RIOT')
+    True
+    >>> is_in_directory('RIOT/../a', 'RIOT')
+    False
+
+    # Also work if path is absolute but not the directory
+    >>> curdir = os.path.abspath(os.curdir)
+    >>> is_in_directory(os.path.join(curdir, 'RIOT', 'a'), 'RIOT')
+    True
+    """
+    directory = os.path.abspath(directory)
+    path = os.path.abspath(path)
+    return path.startswith(directory)
+
+
 class RIOTApplication():
     """RIOT Application representation.
 
@@ -214,6 +232,10 @@ def __init__(self, board, riotdir, appdir, resultdir):
         self.resultdir = os.path.join(resultdir, appdir)
         self.logger = logging.getLogger('%s.%s' % (board, appdir))
 
+        # Currently not handling absolute directories or outside of RIOT
+        assert is_in_directory(self.resultdir, resultdir), \
+            "Application result directory is outside main result directory"
+
     # Extract values from make
     def name(self):
         """Get application name."""