Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

boards/cc2538dk/dist/board.resc: Remove line to make script compatible with latest Renode #11621

Closed
wants to merge 1 commit into from
Closed

boards/cc2538dk/dist/board.resc: Remove line to make script compatible with latest Renode #11621

wants to merge 1 commit into from

Conversation

mgielda
Copy link
Contributor

@mgielda mgielda commented Jun 3, 2019

…e with latest Renode

Contribution description

Testing procedure

Issues/PRs references

@mgielda mgielda changed the title boards/cc2558dk/dist/board.resc: Remove line to make script compatibl… boards/cc2558dk/dist/board.resc: Remove line to make script compatible with latest Renode Jun 3, 2019
@miri64 miri64 self-requested a review July 30, 2019 17:24
@miri64 miri64 self-assigned this Jul 30, 2019
@miri64 miri64 added Area: boards Area: Board ports Area: tools Area: Supplementary tools Platform: ARM Platform: This PR/issue effects ARM-based platforms labels Jul 30, 2019
@miri64
Copy link
Member

miri64 commented Jul 30, 2019

Please make the release message shorter (below 72 chars if possible e.g.

cc2538dk: assure compliance with newest renode release

Also, the board is called cc2538dk not cc2558dk, so please fix that as well.

@miri64
Copy link
Member

miri64 commented Jul 30, 2019

Also, please provide some testing procedures. I installed the latest Renode release on my Ubuntu 19.04 machine, but was unable to interact with the opened renode session. Neither on master nor in this PR.

@miri64 miri64 mentioned this pull request Aug 5, 2019
Closed
@stale
Copy link

stale bot commented Jan 31, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you want me to ignore this issue, please mark it with the "State: don't stale" label. Thank you for your contributions.

@stale stale bot added the State: stale State: The issue / PR has no activity for >185 days label Jan 31, 2020
@fjmolinas
Copy link
Contributor

https://github.com/RIOT-OS/RIOT/pull/13136/files slipped unaware of the existence of this PR. Never the less it makes this PR no longer relevant. Sorry for not reviewing this quicker.

@fjmolinas fjmolinas closed this Feb 1, 2020
@mgielda mgielda changed the title boards/cc2558dk/dist/board.resc: Remove line to make script compatible with latest Renode boards/cc2538dk/dist/board.resc: Remove line to make script compatible with latest Renode May 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miri64 miri64 Awaiting requested review from miri64

Assignees

@miri64 miri64

Labels
Area: boards Area: Board ports Area: tools Area: Supplementary tools Platform: ARM Platform: This PR/issue effects ARM-based platforms State: stale State: The issue / PR has no activity for >185 days
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mgielda @miri64 @fjmolinas