Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests/netstats_l2: use BOARD_WHITELIST #11661

Merged
merged 1 commit into from Jun 11, 2019
Merged

tests/netstats_l2: use BOARD_WHITELIST #11661

merged 1 commit into from Jun 11, 2019

Conversation

cladmi
Copy link
Contributor

@cladmi cladmi commented Jun 7, 2019 •
edited

Contribution description

Use BOARD_WHITELIST instead of calculating BOARD_BLACKLIST from BOARDS.

The output of make info-boards-supported kept the same.

This was found during a cleanup to define BOARDS globally.

Note: this was the only use case found for this pattern in the repository

Testing procedure

The output of supported boards is the same as in master

make --no-print-directory -C tests/netstats_l2/ info-boards-supported
airfy-beacon esp32-mh-et-live-minikit esp32-olimex-evb esp32-wemos-lolin-d32-pro esp32-wroom-32 esp32-wrover-kit fox iotlab-m3 mulle native nrf51dk nrf51dongle nrf6310 pba-d-01-kw2x samd21-xpro saml21-xpro samr21-xpro spark-core yunjia-nrf51822

Issues/PRs references

Cleaning of the BOARDS definition #11662

@cladmi
tests/netstats_l2: use BOARD_WHITELIST
33b3b5f 
Use BOARD_WHITELIST instead of calculating BOARD_BLACKLIST from BOARDS.

The output of `make info-boards-supported` kept the same.
@cladmi cladmi added Area: build system Area: Build system Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Jun 7, 2019
@cladmi cladmi added this to the Release 2019.07 milestone Jun 7, 2019
smlng
smlng approved these changes Jun 11, 2019
View reviewed changes
Copy link
Member

@smlng smlng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What a beautiful example of: why simple when there is a more complex way to achieve the same 😬
Anyway, nice find!

Tested on master and this PR result of make -C tests/netstat_l2 info-boards-supported stays the same.

@smlng smlng added Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines labels Jun 11, 2019
@cladmi
Copy link
Contributor Author

cladmi commented Jun 11, 2019

why simple when there is a more complex way to achieve the same

It's a nice Shadoks reference :)

Thank you for the review. CI is green and runs all the whitelisted boards

airfy-beacon:gnu, esp32-mh-et-live-minikit:gnu, esp32-olimex-evb:gnu, esp32-wemos-lolin-d32-pro:gnu, esp32-wroom-32:gnu, esp32-wrover-kit:gnu, fox:gnu, iotlab-m3:gnu, iotlab-m3:llvm, mulle:gnu, mulle:llvm, native:gnu, native:llvm, nrf51dk:gnu, nrf51dongle:gnu, nrf6310:gnu, pba-d-01-kw2x:gnu, samd21-xpro:gnu, saml21-xpro:gnu, samr21-xpro:gnu, samr21-xpro:llvm, spark-core:gnu, yunjia-nrf51822:gnu

@cladmi cladmi merged commit 0119827 into RIOT-OS:master Jun 11, 2019
@cladmi cladmi deleted the pr/tests/netstats_l2 branch June 11, 2019 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smlng smlng smlng approved these changes

@jcarrano jcarrano Awaiting requested review from jcarrano

@MrKevinWeiss MrKevinWeiss Awaiting requested review from MrKevinWeiss

Assignees
No one assigned
Labels
Area: build system Area: Build system CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
Projects
None yet
Milestone
Release 2019.07
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cladmi @smlng