Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests/lua_loader: run the test in CI #11686

Merged
merged 1 commit into from Jul 26, 2019
Merged

tests/lua_loader: run the test in CI #11686

merged 1 commit into from Jul 26, 2019

Conversation

cladmi
Copy link
Contributor

@cladmi cladmi commented Jun 13, 2019 •
edited

Contribution description

Enable running the test as the test is available.

Testing procedure

The test must be successfully executed by CI (check the listed tests).

Issues/PRs references

Found it was not enabled while working on #11680

I blacklisted native due to #11691

@cladmi cladmi added Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: run tests If set, CI server will run tests on hardware for the labeled PR CI: disable test cache If set, CI will always run all tests regardless of whether they have been run successfully before labels Jun 13, 2019
@cladmi cladmi added this to the Release 2019.07 milestone Jun 13, 2019
This was referenced Jun 13, 2019
Merged
Closed
@cladmi
Copy link
Contributor Author

cladmi commented Jun 13, 2019

tests/lua_loader test is not working on samr21-xpro #11525

jcarrano
jcarrano approved these changes Jun 13, 2019
View reviewed changes
Copy link
Contributor

@jcarrano jcarrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just found out that the TEST_ON_CI_WHITELIST is required.

@cladmi cladmi mentioned this pull request Jun 13, 2019
Closed
@cladmi cladmi force-pushed the pr/tests/lua_loader/enable_in_ci branch from 90ced06 to 8b08118 Compare June 25, 2019 14:32
@cladmi
Copy link
Contributor Author

cladmi commented Jun 25, 2019

Blacklisted native and rebased on master now that it should works on samr21-xpro again.

@cladmi
Copy link
Contributor Author

cladmi commented Jun 25, 2019

@jcarrano I blacklisted native and the test work rebased on the current master. Tell me when I can squash.

@jcarrano
Copy link
Contributor

@cladmi squash

@cladmi
tests/lua_loader: run the test in CI
ce58a32 
HACK, the test currently fails in CI for `native` due to `utf-8` handling.
@cladmi cladmi force-pushed the pr/tests/lua_loader/enable_in_ci branch from fc20496 to ce58a32 Compare July 12, 2019 16:52
@cladmi
Copy link
Contributor Author

cladmi commented Jul 12, 2019

Rebased to use TESTS_ON_CI_BLACKLIST #11743.
I blacklisted native due to #11691

@jcarrano jcarrano merged commit 7d3817e into RIOT-OS:master Jul 26, 2019
@cladmi
Copy link
Contributor Author

cladmi commented Jul 29, 2019

Thank you for the review!

@cladmi cladmi deleted the pr/tests/lua_loader/enable_in_ci branch July 29, 2019 06:46
@kb2ma kb2ma added this to the Release 2019.10 milestone Sep 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcarrano jcarrano jcarrano approved these changes

@leandrolanzieri leandrolanzieri Awaiting requested review from leandrolanzieri leandrolanzieri is a code owner

Assignees
No one assigned
Labels
Area: tests Area: tests and testing framework CI: disable test cache If set, CI will always run all tests regardless of whether they have been run successfully before CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: run tests If set, CI server will run tests on hardware for the labeled PR
Projects
None yet
Milestone
Release 2019.10
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cladmi @jcarrano @kb2ma @MrKevinWeiss