Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stm32_common/gpio: remove unused guard #11893

Merged
merged 1 commit into from Jul 25, 2019
Merged

stm32_common/gpio: remove unused guard #11893

merged 1 commit into from Jul 25, 2019

Conversation

fjmolinas
Copy link
Contributor

Contribution description

This PR removes an unneeded guard for stm32f0, there was a typo in the ifdef and since RCC_APB2ENR_SYSCFGCOMPEN is mapped to RCC_APB2ENR_SYSCFGEN in the CMSIS this is not needed (if it ever was).

Testing procedure

A green murdock should be enough.

Issues/PRs references

@fjmolinas fjmolinas added Platform: ARM Platform: This PR/issue effects ARM-based platforms Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Jul 23, 2019
@fjmolinas fjmolinas requested a review from aabadie July 23, 2019 15:09
@fjmolinas
Copy link
Contributor Author

fjmolinas commented Jul 24, 2019 •
edited

@benpicco thanks for the review!

@miri64 Although this is quite trivial, I guess protocol dictates you should take a look before @benpicco can merge... EDIT: I'm assuming that is why @benpicco didn't merge

@fjmolinas
Copy link
Contributor Author

@benpicco I think we can just go ahead and merge this one, its really a trivial fix, I don't think we need to wait for @miri64 or @kaspar030 to take a look.

Would do you want to hit the button?

@benpicco benpicco merged commit b411d71 into RIOT-OS:master Jul 25, 2019
@fjmolinas fjmolinas deleted the pr_stm32f0_gpio_typo branch July 25, 2019 16:42
@kb2ma kb2ma added this to the Release 2019.10 milestone Sep 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benpicco benpicco benpicco approved these changes

@aabadie aabadie Awaiting requested review from aabadie aabadie is a code owner

Assignees
No one assigned
Labels
CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: ARM Platform: This PR/issue effects ARM-based platforms Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
Projects
None yet
Milestone
Release 2019.10
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fjmolinas @benpicco @kb2ma