cpu/lpc2387: Cleanup #11920
Merged
cpu/lpc2387: Cleanup #11920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The MSB-A2 and the Avsextrem board once had support for using the USB interface of the LPC2387. The code setting up the USB clock has been unused for ages and is now defunct, as the required value for `USBCLKDivValue` is no longer present in RIOT's code base. This commits removes the defunct and unused code.
- Functions bl_uart_init(), bl_blink(), bl_config_init() declared but never
implemented
--> Removed declarations
- Check for c preprocessor macro CPU_MC1322X is obsolete, as CPU_MC1322X is
nowhere defined in RIOT's code base
- IRQ_Routine() is never used, nor is it ever configured as ISR
- DEBUG_Routine() is never used, nor is it ever configured as ISR
- split up interrupt vector code from bootloader.c to vectors.c
- moved bootloader.c to arm7_init.c
- Use consistent naming:
- use lower case for everything but preprocessor stuff
- ISRs now named isr_foo()
maribu
added
Platform: ARM
|
@PeterKietzmann: Mind to review also this one? |
benpicco
added
the
CI: ready for build
benpicco
approved these changes
Sep 10, 2019
There was a problem hiding this comment.
I don't have the hardware to test, but even though this looks scary at first, it's actually no big changes:
- the first two commits just remove dead code. CI makes sure that those #ifdefs really always have been false.
- the third commit just moves code around and renames a few functions. No functional change here. CI will make sure that the old names are not used anymore.
|
Thanks for the review! :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: The boot up sequence of the LPC2387 is quite weird, with clock setup in the
boards/rather than incpu/. I intend to clean this up with a series of PRs. A side effect from the code organization is that this PR touches files in seemingly unrelated subsystems...Contribution description
bootloader.cvector.cand applied naming scheme used by other modules incpu/arm7_init.c.Testing procedure
Try to build, flash, and run some applications and tests currently working on the MSB-A2. They should still work
Issues/PRs references
One of many steps to address #4693