New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cpu/esp8266: Moved stdio_init before periph_init #12225
Conversation
@gschorcht, @benpicco: My ESP8266s and ESP32s are all at office, so this and #12224 are completely untested so far ;-) |
Hm, no matter where I stick this in in If I put it back into #ifdef MODULE_NEWLIB_SYSCALLS_DEFAULT
_init();
#endif in |
- This guarantees that DEBUG() is available early in boot process - Forgotten in RIOT-OS#11367, this fixes broken stdio
2923864
to
baf911b
Compare
@benpicco: Please test again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I see double.
I'll ponder why all the init functions are there twice at another time, now this is working again.
Tested on esp8266-esp-12x
.
Thanks for testing and nothing the bug, and the bug in the bugfix :-D |
There are two different startup functions for ESP8266, one if bare metal implementation without the terrible Espressif SDK is used used and one if the Espressif SDK is used ( |
Contribution description
Added a call to
stdio_init()
right before calling `periph_init().Testing procedure
Flash and run e.g.
examples/default
orexamples/hello-world
and see if stdio is working againIssues/PRs references
Fixes bug introduced in #11367