Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

makefiles: fix LOG_LEVEL handling #12823

Merged
merged 1 commit into from Nov 27, 2019
Merged

makefiles: fix LOG_LEVEL handling #12823

merged 1 commit into from Nov 27, 2019

Conversation

gschorcht
Copy link
Contributor

Contribution description

This PR fixes the test of CFLAGS in the handling of the LOG_LEVEL variable.

PR #11592 introduced a change that should make it possible to define the LOG_LEVEL at the make command line if LOG_LEVEL isn't already set in CFLAGS. However, a wrong test of the variable CFLAGS has avoided this.

Testing procedure

Issues/PRs references

Fixes the change in PR #11592

@gschorcht gschorcht added Area: build system Area: Build system CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) labels Nov 27, 2019
kaspar030
kaspar030 approved these changes Nov 27, 2019
View reviewed changes
Copy link
Contributor

@kaspar030 kaspar030 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK.

aabadie
aabadie approved these changes Nov 27, 2019
View reviewed changes
Copy link
Contributor

@aabadie aabadie left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and this fixes the problem. Thanks @gschorcht :)

@gschorcht gschorcht added the Reviewed: 3-testing The PR was tested according to the maintainer guidelines label Nov 27, 2019
@aabadie aabadie merged commit f318572 into RIOT-OS:master Nov 27, 2019
@gschorcht gschorcht deleted the make/fix_log_level branch November 27, 2019 16:55
@fjmolinas fjmolinas added this to the Release 2020.01 milestone Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aabadie aabadie aabadie approved these changes

@kaspar030 kaspar030 kaspar030 approved these changes

Assignees
No one assigned
Labels
Area: build system Area: Build system CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Reviewed: 3-testing The PR was tested according to the maintainer guidelines Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Milestone
Release 2020.01
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gschorcht @aabadie @kaspar030 @fjmolinas