Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RIOT default license header change #1329

Merged
merged 5 commits into from Jul 31, 2014

Conversation

LudwigKnuepfer
Copy link
Member

Actual text is up for discussion, I think we more or less agreed on this one.

When we agree upon a text, there are some more files to be changed (see license checker output for lgpl* files).

@LudwigKnuepfer LudwigKnuepfer added this to the FIX ME FIRST milestone Jun 18, 2014
@LudwigKnuepfer
Copy link
Member Author

milestone is FIX ME FIRST because it's part of fixing #392

@LudwigKnuepfer
Copy link
Member Author

Lines for applying a $LICENSE (with some escaped characters):

$ for FILE in $(cat dist/tools/licenses/out/lgpl-short-riot); do
sed -i -e '/This file is subject to the terms and conditions of the GNU Lesser General/,/details/c'${LICENSE} ${FILE}
done

@kaspar030
Copy link
Contributor

Just for the record, "or any later version" is part of this PR and does not reflect the actual license change from GPLv3 some months ago.

@LudwigKnuepfer
Copy link
Member Author

@kaspar030 Why?
We (would) still license everything as lgplv2.1 only allowing others to relicense.

@kaspar030
Copy link
Contributor

@LudwigOrtmann Exactly. But we decided specifically to use LGPV2.1, not "any later version".

A relicensed fork's changes would be incompatible with "our" codebase.

I hate licences.

@OlegHahm
Copy link
Member

I would also vote against importing this "or any later version" here. AFAIK there was no consensus about this (and not all authors were asked).

And I would still vote for longer lines to save some line breaks.

@LudwigKnuepfer
Copy link
Member Author

Did as you suggested.

@LudwigKnuepfer
Copy link
Member Author

Huh, I guess I messed up the license text while rewrapping .... fixing.

@LudwigKnuepfer
Copy link
Member Author

Is this better?

@OlegHahm
Copy link
Member

Actually I think I'm the wrong person to review this PR. Is there anyone volunteering?

@LudwigKnuepfer
Copy link
Member Author

rebased, text fixed.

@LudwigKnuepfer
Copy link
Member Author

rebased

@LudwigKnuepfer
Copy link
Member Author

@OlegHahm Do you think we should put this on the mailing list or take it to the next developers meeting? As it is now, it's only a cosmetic header change.

@OlegHahm
Copy link
Member

Give it a try on the mailing list, I would say.

@LudwigKnuepfer
Copy link
Member Author

The mailing list refused to answer.

@LudwigKnuepfer
Copy link
Member Author

Nobody seems have anything to say, I suggest I change to the minimal version (compare #1396) - at least nobody dislikes it and it is compatible with the existing one. Then we can merge it and see what the future brings.

@haukepetersen
Copy link
Contributor

I am fine with this license -> ACK (for the long version)

@OlegHahm
Copy link
Member

ACK for the short version.

@LudwigKnuepfer
Copy link
Member Author

One more ACK to decide this issue, gogogo =)

@kaspar030
Copy link
Contributor

ACK for the short version, too. (thats not this one, right?)

@LudwigKnuepfer
Copy link
Member Author

@kaspar030 You're right it's not presently visible, I'll update.

@LudwigKnuepfer
Copy link
Member Author

This should be it... phew.

See the file LICENSE in the top level directory for more details.
* This file is subject to the terms and conditions of the GNU Lesser
* General Public License v2.1. See the file LICENSE in the top level
* directory for more details.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks strange.

@OlegHahm
Copy link
Member

The rest is ACK.

@LudwigKnuepfer
Copy link
Member Author

fixed and rebased and squashed

@OlegHahm
Copy link
Member

ACK.

LudwigKnuepfer added a commit that referenced this pull request Jul 31, 2014
RIOT default license header change
@LudwigKnuepfer LudwigKnuepfer merged commit d55da67 into RIOT-OS:master Jul 31, 2014
@LudwigKnuepfer LudwigKnuepfer deleted the riot_license branch July 31, 2014 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: doc Area: Documentation Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants