New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RIOT default license header change #1329
Conversation
milestone is FIX ME FIRST because it's part of fixing #392 |
Lines for applying a
|
Just for the record, "or any later version" is part of this PR and does not reflect the actual license change from GPLv3 some months ago. |
@kaspar030 Why? |
@LudwigOrtmann Exactly. But we decided specifically to use LGPV2.1, not "any later version". A relicensed fork's changes would be incompatible with "our" codebase. I hate licences. |
I would also vote against importing this "or any later version" here. AFAIK there was no consensus about this (and not all authors were asked). And I would still vote for longer lines to save some line breaks. |
Did as you suggested. |
Huh, I guess I messed up the license text while rewrapping .... fixing. |
Is this better? |
Actually I think I'm the wrong person to review this PR. Is there anyone volunteering? |
rebased, text fixed. |
rebased |
@OlegHahm Do you think we should put this on the mailing list or take it to the next developers meeting? As it is now, it's only a cosmetic header change. |
Give it a try on the mailing list, I would say. |
The mailing list refused to answer. |
Nobody seems have anything to say, I suggest I change to the minimal version (compare #1396) - at least nobody dislikes it and it is compatible with the existing one. Then we can merge it and see what the future brings. |
I am fine with this license -> ACK (for the long version) |
ACK for the short version. |
One more ACK to decide this issue, gogogo =) |
ACK for the short version, too. (thats not this one, right?) |
@kaspar030 You're right it's not presently visible, I'll update. |
This should be it... phew. |
See the file LICENSE in the top level directory for more details. | ||
* This file is subject to the terms and conditions of the GNU Lesser | ||
* General Public License v2.1. See the file LICENSE in the top level | ||
* directory for more details. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That looks strange.
The rest is ACK. |
fixed and rebased and squashed |
ACK. |
RIOT default license header change
Actual text is up for discussion, I think we more or less agreed on this one.
When we agree upon a text, there are some more files to be changed (see license checker output for lgpl* files).